Skip to content

[v22.x backport] worker: make Worker async disposable#58455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 2 commits into from
Jul 28, 2025
Merged

[v22.x backport] worker: make Worker async disposable #58455

aduh95 merged 2 commits into from
Jul 28, 2025

Conversation

@jasnell
Copy link
Member

@jasnelljasnell commented May 26, 2025

Backport of #58385

@jasnelljasnell requested a review from aduh95May 26, 2025 01:04
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. worker Issues and PRs related to Worker support. labels May 26, 2025
@jasnelljasnell changed the title worker: make Worker async disposable[Backport] worker: make Worker async disposableMay 26, 2025
@jasnelljasnell mentioned this pull request May 26, 2025
Closed
@juanarbol
Copy link
Member

juanarbol commented May 26, 2025

Maybe it is quite irrelevant, but this backport diverges a bit from the original PR (one extra commit) and each commit is missing its metadata (trailing, same as the original PR).

@jasnell
Copy link
MemberAuthor

jasnell commented May 26, 2025

This was a manual commit put together before the other one landed. Will update it with the metadata later.

@jasnelljasnellforce-pushed the jasnell/backport-worker-dispose branch from 23474ab to a8ffbcdCompareMay 26, 2025 01:19
juanarbol
juanarbol approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@juanarboljuanarbol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a manual commit put together before the other one landed. Will update it with the metadata later.

Oh, I see. Although, all commits needs its trailers. I think a rebase and a ncu command for each patch will fix it. I'm approving considering that you'll add the git trailers for each commit as it should be.

@jasnell
Copy link
MemberAuthor

jasnell commented May 26, 2025

i'm not planning on back porting both of the original commits since one is only relevant for 24.x. This one commit combines the base change along the 22.x version of the test that landed in the original.

@aduh95aduh95 changed the title [Backport] worker: make Worker async disposable[v22.x backport] worker: make Worker async disposableMay 26, 2025
aduh95
aduh95 reviewed Jun 10, 2025
View reviewed changes
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67390/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 15, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67462/

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68065/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68089/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68123/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68175/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68181/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 27, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68245/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 27, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68249/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68258/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68263/

@jasnell@aduh95
worker: make Worker async disposable
8dbc6b2
PR-URL: nodejs#58385 Backport-PR-URL: nodejs#58455 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@jasnell@aduh95
test: add test for async disposable worker thread
66fccc2
PR-URL: nodejs#58385 Backport-PR-URL: nodejs#58455 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95aduh95force-pushed the jasnell/backport-worker-dispose branch from 514262c to 66fccc2CompareJuly 28, 2025 09:08
@aduh95
Copy link
Contributor

aduh95 commented Jul 28, 2025

Landed in 6905258...66fccc2

@aduh95aduh95 merged commit 66fccc2 into nodejs:v22.x-stagingJul 28, 2025
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes

@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes

@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@juanarbol@nodejs-github-bot@aduh95@Ethan-Arrowood