Skip to content

test: close FileHandle objects in tests explicitly#58615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 9, 2025
Merged

test: close FileHandle objects in tests explicitly #58615

nodejs-github-bot merged 1 commit into from
Jun 9, 2025

Conversation

@jasnell
Copy link
Member

@jasnelljasnell commented Jun 7, 2025•
edited
Loading

Separated out from #58536. Specifically not using using so the test changes can be backported.

This is in preparation for moving the close-filehandle-on-gc to EOL.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 7, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov
Copy link

codecovbot commented Jun 7, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (f58613a) to head (ae8fcd0).
Report is 9 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58615 +/- ## ========================================== + Coverage 90.20% 90.22% +0.01%  ========================================== Files 636 636 Lines 187718 187718 Branches 36855 36870 +15 ========================================== + Hits 169331 169360 +29 + Misses 11153 11123 -30 - Partials 7234 7235 +1

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 7, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 8, 2025•
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/67326/ 💚

@jasnelljasnell added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 8, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2025
@nodejs-github-botnodejs-github-bot merged commit 2eeb65f into nodejs:mainJun 9, 2025
73 of 74 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 9, 2025

Landed in 2eeb65f

seriousme pushed a commit to seriousme/node that referenced this pull request Jun 10, 2025
@jasnell@seriousme
test: close FileHandle objects in tests explicitly
d2efd02
PR-URL: nodejs#58615 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jun 16, 2025
@jasnell@targos
test: close FileHandle objects in tests explicitly
a4d7560
PR-URL: #58615 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@jasnell@aduh95
test: close FileHandle objects in tests explicitly
42e65c1
PR-URL: #58615 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@jasnell@aduh95
test: close FileHandle objects in tests explicitly
3fc630e
PR-URL: #58615 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes

@anonriganonrigAwaiting requested review from anonrig

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@nodejs-github-bot@lpinca@LiviaMedeiros