lib: remove globalPreload support#58743
Open
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jun 17, 2025
Review requested:
|
nodejs-github-bot added esm 
Since the loader is now stable, the warning when using globalPreload is no longer necessary.
The globalPreload warning is no longer emitted, so the related test is removed.
kazuma0129force-pushed the kazuma0129-patch-1 branch from 970c7e7 to f777eabCompare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #58743 +/- ## ========================================== - Coverage 90.15% 90.12% -0.04% ========================================== Files 639 639 Lines 188201 188185 -16 Branches 36915 36914 -1 ========================================== - Hits 169675 169601 -74 - Misses 11274 11316 +42 - Partials 7252 7268 +16
🚀 New features to boost your workflow:
|
lpinca approved these changes Jun 17, 2025
mcollina added semver-major 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jun 18, 2025
JakobJingleheimer approved these changes Jun 18, 2025
Member
JakobJingleheimer left a comment
JakobJingleheimer left a comment There was a problem hiding this comment.
Loaders aren't stable, but I think it's been enough time to remove.
In an abundance of caution though, perhaps let's mark this major?
Ethan-Arrowood approved these changes Jun 18, 2025
jasnell approved these changes Jun 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved TODO left at #49144.