test_runner: correct "already mocked" error punctuation placement

[JakobJingleheimer]

The current message contains a period within the quotes around the specifier, making it look malformed.

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[github-actions]

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (b4c5fb4) to head (894aad1).
Report is 2 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #58840 +/- ## ========================================== + Coverage 90.08% 90.10% +0.02%  ========================================== Files 640 640 Lines 188446 188446 Branches 36960 36966 +6 ========================================== + Hits 169757 169798 +41 + Misses 11412 11359 -53 - Partials 7277 7289 +12 

Files with missing lines	Coverage Δ
lib/internal/test_runner/mock/mock.js	99.27% <100.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67666/

[tniessen]

FWIW, having punctuation inside quotes is the writing style I have been taught, but I think marking an identifier using '...' does not qualify as a quote, so LGTM.

[JakobJingleheimer]

Sooo the rule for this is when the quoted text is a complete sentence that has its own terminal punctuation:

I told him "I'm hungry!".

When it's not, it doesn't:

It's called "fashion".

In both cases, there is always terminal punctuation after the quotes 🙂

EDIT: But yes, I think the more important issue is not reporting the specifier in a misleading way. Cannot mock 'nonexistent.mjs.' The module is already mocked. makes the specifier look like it contains a trailing . when it actually doesn't.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/58840 ✔ Done loading data for nodejs/node/pull/58840 ----------------------------------- PR info ------------------------------------ Title test_runner: correct "already mocked" error punctuation placement (#58840) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch JakobJingleheimer:testrunner/fix/already-mocked-error-message -> nodejs:main Labels fast-track, needs-ci, test_runner Commits 1 - test_runner: correct "already mocked" error punctuation placement Committers 1 - Jacob Smith <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58840 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58840 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 26 Jun 2025 10:01:34 GMT ✔ Approvals: 3 ✔ - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/58840#pullrequestreview-2961537077 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58840#pullrequestreview-2962262634 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/58840#pullrequestreview-2962468027 ℹ This PR is being fast-tracked ✘ This PR needs to wait 38 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-26T14:13:20Z: https://ci.nodejs.org/job/node-test-pull-request/67666/ - Querying data for job/node-test-pull-request/67666/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/15910286689

[JakobJingleheimer]

Ugh. Could I get 1 more 👍 on the fast-track please

[nodejs-github-bot]

Landed in 5b0c7db