Skip to content

build: disable v8_enable_pointer_compression_shared_cage on non-64bit#58867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 30, 2025
Merged

build: disable v8_enable_pointer_compression_shared_cage on non-64bit #58867

nodejs-github-bot merged 1 commit into from
Jun 30, 2025

Conversation

@codebytere
Copy link
Member

@codebyterecodebytere commented Jun 27, 2025

Refs #58171

Ensure v8_enable_pointer_compression_shared_cage is also disabled on non-64-bit architectures, as V8 pointer compression only supports 64bit architectures.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2025

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 27, 2025
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67687/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67692/

@codebyterecodebytere removed the needs-ci PRs that need a full CI run. label Jun 28, 2025
@codebyterecodebytere mentioned this pull request Jun 28, 2025
Merged
@codebyterecodebytere added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 30, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2025
@nodejs-github-botnodejs-github-bot merged commit ab9ef37 into nodejs:mainJun 30, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 30, 2025

Landed in ab9ef37

targos pushed a commit that referenced this pull request Jul 3, 2025
@codebytere@targos
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
c76585d
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jul 8, 2025
Merged
Fervv268
Fervv268 reviewed Jul 18, 2025
View reviewed changes
Copy link

@Fervv268Fervv268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Siemanko

aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@codebytere@aduh95
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
0e62775
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@codebytere@aduh95
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
f7c1698
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jul 28, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 18, 2025
@codebytere@marco-ippolito
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
978e931
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Aug 20, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@codebytere@marco-ippolito
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
71de35c
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 23, 2025
@codebytere@marco-ippolito
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
0234096
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@codebytere@marco-ippolito
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
3abe213
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@codebytere@marco-ippolito
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
d5d5352
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@codebytere@marco-ippolito
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
294beb6
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 26, 2025
@codebytere@marco-ippolito
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
b2c93f5
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
@codebytere@marco-ippolito
build: disable v8_enable_pointer_compression_shared_cage on non-64bit
d2c5e60
PR-URL: #58867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@richardlaurichardlaurichardlau approved these changes

@RafaelGSSRafaelGSSRafaelGSS approved these changes

@zcbenzzcbenzAwaiting requested review from zcbenz

@joyeecheungjoyeecheungAwaiting requested review from joyeecheung

+1 more reviewer

@Fervv268Fervv268Fervv268 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@codebytere@nodejs-github-bot@jasnell@lpinca@richardlau@RafaelGSS@Fervv268