Skip to content

src: fix a series of -Wno-unreachable-code errors#58901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codebytere wants to merge 4 commits into from
Closed

src: fix a series of -Wno-unreachable-code errors #58901

codebytere wants to merge 4 commits into from

Conversation

@codebytere
Copy link
Member

@codebyterecodebytere commented Jun 30, 2025

Tweaks to fix the following:

  • -Wno-unreachable-code
  • -Wno-unreachable-code-break
  • -Wno-unreachable-code-return

@codebyterecodebytere requested a review from jasnellJune 30, 2025 09:59
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 30, 2025

Review requested:

  • @nodejs/crypto
  • @nodejs/node-api

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 30, 2025
@codecov
Copy link

codecovbot commented Jun 30, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (8b199ee) to head (c6a8fa3).
⚠️ Report is 660 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58901 +/- ## ======================================= Coverage 90.11% 90.11% ======================================= Files 640 640 Lines 188426 188426 Branches 36955 36959 +4 ======================================= + Hits 169796 169800 +4 + Misses 11351 11337 -14 - Partials 7279 7289 +10
Files with missing linesCoverage Δ
src/crypto/crypto_context.cc69.16% <ø> (ø)
src/node_api.cc76.16% <ø> (ø)
src/node_config_file.cc80.55% <ø> (ø)
src/node_contextify.cc81.24% <ø> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleaxaddaleax added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 30, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 30, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67754/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67759/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67781/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67838/

@legendecaslegendecas added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jul 4, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2025
nodejs-github-bot pushed a commit that referenced this pull request Jul 4, 2025
@codebytere@nodejs-github-bot
src: fix -Wunreachable-code in src/node_api.cc
06b0987
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2025

Landed in 560d00f...813b4e8

nodejs-github-bot pushed a commit that referenced this pull request Jul 4, 2025
@codebytere@nodejs-github-bot
src: fix -Wunreachable-code-return in src/node_contextify.cc
f2ca1ec
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jul 4, 2025
@codebytere@nodejs-github-bot
src: -Wunreachable-code error in crypto_context.cc
51d9f3f
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jul 4, 2025
@codebytere@nodejs-github-bot
src: -Wunreachable-code-break in node_config_file.cc
813b4e8
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@codebytere@RafaelGSS
src: fix -Wunreachable-code in src/node_api.cc
ba66145
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@codebytere@RafaelGSS
src: fix -Wunreachable-code-return in src/node_contextify.cc
056a1af
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@codebytere@RafaelGSS
src: -Wunreachable-code error in crypto_context.cc
143379d
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@codebytere@RafaelGSS
src: -Wunreachable-code-break in node_config_file.cc
8eecaa2
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@codebytere@aduh95
src: fix -Wunreachable-code-return in src/node_contextify.cc
d1361a2
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@codebytere@aduh95
src: -Wunreachable-code error in crypto_context.cc
f965aee
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@codebytere@aduh95
src: fix -Wunreachable-code in src/node_api.cc
c07cff7
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@codebytere@aduh95
src: fix -Wunreachable-code-return in src/node_contextify.cc
2d8e65c
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@codebytere@aduh95
src: -Wunreachable-code error in crypto_context.cc
6d1fe67
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@codebytere@aduh95
src: fix -Wunreachable-code in src/node_api.cc
c5040ac
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 27, 2025
@codebytere@aduh95
src: fix -Wunreachable-code in src/node_api.cc
b722647
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jul 28, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 18, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
b8221b8
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
0477508
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Aug 20, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
18f003b
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 23, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
4236189
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
dad5473
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
b51438e
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
c37aae0
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
f53a6eb
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 26, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
b55a325
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code in src/node_api.cc
80fb80e
PR-URL: #58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
geeksilva97 pushed a commit to geeksilva97/node that referenced this pull request Sep 20, 2025
@codebytere@geeksilva97
src: -Wunreachable-code-break in node_config_file.cc
ec376b2
PR-URL: nodejs#58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
geeksilva97 pushed a commit to geeksilva97/node that referenced this pull request Sep 20, 2025
@codebytere@geeksilva97
src: -Wunreachable-code-break in node_config_file.cc
339affe
PR-URL: nodejs#58901 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
@geeksilva97geeksilva97 mentioned this pull request Sep 20, 2025
Closed
@aduh95aduh95 added the backported-to-v22.x PRs backported to the v22.x-staging branch. label Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@vmorozvmorozvmoroz approved these changes

@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backported-to-v22.xPRs backported to the v22.x-staging branch.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@codebytere@nodejs-github-bot@jasnell@addaleax@vmoroz@legendecas@aduh95