test: fix flaky test-worker-message-port-transfer-filehandle test

[himself65]

Fixes: #59145

Wrap all script into setInterval and you will see the error

'use strict';constcommon=require('../common');constassert=require('assert');constfs=require('fs').promises;constvm=require('vm');const{ MessageChannel, moveMessagePortToContext }=require('worker_threads');const{ once }=require('events');setInterval(async()=>{(asyncfunction(){constfh=awaitfs.open(__filename);const{ port1, port2 }=newMessageChannel();assert.throws(()=>{port1.postMessage(fh);},{constructor: DOMException,name: 'DataCloneError',code: 25,});// Check that transferring FileHandle instances works.assert.notStrictEqual(fh.fd,-1);port1.postMessage(fh,[fh]);assert.strictEqual(fh.fd,-1);const[fh2]=awaitonce(port2,'message');assert.strictEqual(Object.getPrototypeOf(fh2),Object.getPrototypeOf(fh));assert.deepStrictEqual(awaitfh2.readFile(),awaitfs.readFile(__filename));awaitfh2.close();awaitassert.rejects(()=>fh.readFile(),{code: 'EBADF'});})().then(common.mustCall());(asyncfunction(){// Check that there is no crash if the message is never read.constfh=awaitfs.open(__filename);const{ port1 }=newMessageChannel();assert.notStrictEqual(fh.fd,-1);port1.postMessage(fh,[fh]);assert.strictEqual(fh.fd,-1);})().then(common.mustCall());(asyncfunction(){// Check that in the case of a context mismatch the message is discarded.constfh=awaitfs.open(__filename);const{ port1, port2 }=newMessageChannel();constctx=vm.createContext();constport2moved=moveMessagePortToContext(port2,ctx);port2moved.onmessage=common.mustCall((msgEvent)=>{assert.strictEqual(msgEvent.data,'second message');port1.close();});// TODO(addaleax): Switch this to a 'messageerror' event once MessagePort// implements EventTarget fully and in a cross-context manner.port2moved.onmessageerror=common.mustCall((event)=>{assert.strictEqual(event.data.code,'ERR_MESSAGE_TARGET_CONTEXT_UNAVAILABLE');});port2moved.start();assert.notStrictEqual(fh.fd,-1);port1.postMessage(fh,[fh]);assert.strictEqual(fh.fd,-1);port1.postMessage('second message');})().then(common.mustCall());(asyncfunction(){// Check that a FileHandle with a read in progress cannot be transferred.constfh=awaitfs.open(__filename);const{ port1 }=newMessageChannel();constreadPromise=fh.readFile();assert.throws(()=>{port1.postMessage(fh,[fh]);},{message: 'Cannot transfer FileHandle while in use',name: 'DataCloneError'});assert.deepStrictEqual(awaitreadPromise,awaitfs.readFile(__filename));// await fh.close();})().then(common.mustCall());(asyncfunction(){// Check that filehandles with a close in progress cannot be transferred.constfh=awaitfs.open(__filename);const{ port1 }=newMessageChannel();constclosePromise=fh.close();assert.throws(()=>{port1.postMessage(fh,[fh]);},{message: 'Cannot transfer FileHandle while in use',name: 'DataCloneError'});awaitclosePromise;})().then(common.mustCall());},10)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (2a7fb0a) to head (9b9369c).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59158 +/- ## ========================================== - Coverage 90.03% 90.02% -0.01%  ========================================== Files 648 648 Lines 190986 190986 Branches 37438 37434 -4 ========================================== - Hits 171959 171944 -15 - Misses 11667 11669 +2 - Partials 7360 7373 +13 

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/59158 ✔ Done loading data for nodejs/node/pull/59158 ----------------------------------- PR info ------------------------------------ Title test: fix flaky test-worker-message-port-transfer-filehandle test (#59158) Author Alex Yang <[email protected]> (@himself65) Branch himself65:himself65/2025/07/22/close -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: fix flaky test-worker-message-port-transfer-filehandle test Committers 1 - Alex Yang <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59158 Fixes: https://github.com/nodejs/node/issues/59145 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59158 Fixes: https://github.com/nodejs/node/issues/59145 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 22 Jul 2025 08:13:10 GMT ✔ Approvals: 2 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/59158#pullrequestreview-3043549566 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59158#pullrequestreview-3044489929 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-07-24T06:59:56Z: https://ci.nodejs.org/job/node-test-pull-request/68162/ - Querying data for job/node-test-pull-request/68162/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/16491782083

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68206/

[nodejs-github-bot]

Landed in 5e86ad9