sqlite: fix crash session extension callbacks with workers

[louwers]

This PR fixes the problem that static std::function variables are used to store callbacks. This causes problems when SQLite is used (also) used from a worker and can result in a crash.

This PR stack allocates the callbacks and passes it along to sqlite3changeset_apply via the context argument.

It also adds a regression test which crashes out before this change.

Lastly some functionality that is uses in test/parallel/test-sqlite.js is now also needed in test/parallel/test-sqlite-session.js so I factored that out to a different file.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.63%. Comparing base (861d624) to head (5ae2b74).
⚠️ Report is 78 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #59848 +/- ## ========================================== + Coverage 88.26% 88.63% +0.37%  ========================================== Files 701 703 +2 Lines 206774 212129 +5355 Branches 39778 45065 +5287 ========================================== + Hits 182514 188030 +5516 + Misses 16298 16114 -184 - Partials 7962 7985 +23 

Files with missing lines	Coverage Δ
src/node_sqlite.cc	86.56% <85.00%> (+5.04%)	⬆️

... and 125 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[louwers]

@addaleax Could you trigger a CI run?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69179/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69246/

[louwers]

@addaleax Could you merge it?

[louwers]

@nodejs/sqlite

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69286/

[louwers]

@nodejs/sqlite Any blockers?

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/59848 ✔ Done loading data for nodejs/node/pull/59848 ----------------------------------- PR info ------------------------------------ Title sqlite: fix crash session extension callbacks with workers (#59848) Author Bart Louwers <[email protected]> (@louwers) Branch louwers:fix-crash-sqlite -> nodejs:main Labels c++, author ready, needs-ci, sqlite Commits 6 - sqlite: fix crash session extension callbacks with workers - test: fix inclusion of common module - Update src/node_sqlite.cc - Update src/node_sqlite.cc - sqlite: fix compilation - sqlite: run formatter Committers 2 - Bart Louwers <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 10 Sep 2025 21:31:15 GMT ✔ Approvals: 3 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/59848#pullrequestreview-3210402428 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/59848#pullrequestreview-3247082140 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/59848#pullrequestreview-3247086754 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-09-19T21:05:02Z: https://ci.nodejs.org/job/node-test-pull-request/69286/ - Querying data for job/node-test-pull-request/69286/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 59848 From https://github.com/nodejs/node * branch refs/pull/59848/merge -> FETCH_HEAD ✔ Fetched commits as 0a72b2cd7b5f..5ae2b741a506 -------------------------------------------------------------------------------- Auto-merging src/node_sqlite.cc [main 708684e395] sqlite: fix crash session extension callbacks with workers Author: Bart Louwers <[email protected]> Date: Wed Sep 10 23:21:19 2025 +0200 5 files changed, 128 insertions(+), 22 deletions(-) create mode 100644 test/sqlite/next-db.js create mode 100644 test/sqlite/worker.js [main af6bc0b143] test: fix inclusion of common module Author: Bart Louwers <[email protected]> Date: Thu Sep 11 00:03:02 2025 +0200 2 files changed, 2 insertions(+), 2 deletions(-) Auto-merging src/node_sqlite.cc [main b0dc4b31d4] Update src/node_sqlite.cc Author: Bart Louwers <[email protected]> Date: Thu Sep 11 02:00:32 2025 +0200 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging src/node_sqlite.cc [main eb31476ac6] Update src/node_sqlite.cc Author: Bart Louwers <[email protected]> Date: Thu Sep 11 02:00:44 2025 +0200 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging src/node_sqlite.cc [main ba64b2a1e4] sqlite: fix compilation Author: Bart Louwers <[email protected]> Date: Thu Sep 11 02:23:30 2025 +0200 1 file changed, 3 insertions(+), 2 deletions(-) Auto-merging src/node_sqlite.cc [main 2c17b89167] sqlite: run formatter Author: Bart Louwers <[email protected]> Date: Thu Sep 11 10:55:33 2025 +0200 1 file changed, 8 insertions(+), 6 deletions(-) ✔ Patches applied There are 6 commits in the PR. Attempting autorebase. Rebasing (2/12) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- sqlite: fix crash session extension callbacks with workers 
PR-URL: #59848
 Reviewed-By: Anna Henningsen <[email protected]>
 Reviewed-By: Zeyu "Alex" Yang <[email protected]>
 Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 2a75159701] sqlite: fix crash session extension callbacks with workers
 Author: Bart Louwers <[email protected]>
 Date: Wed Sep 10 23:21:19 2025 +0200
 5 files changed, 128 insertions(+), 22 deletions(-)
 create mode 100644 test/sqlite/next-db.js
 create mode 100644 test/sqlite/worker.js
 Rebasing (3/12)
 Rebasing (4/12)
 Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 test: fix inclusion of common module
PR-URL: #59848
 Reviewed-By: Anna Henningsen <[email protected]>
 Reviewed-By: Zeyu "Alex" Yang <[email protected]>
 Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 44cc0b74ae] test: fix inclusion of common module
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 00:03:02 2025 +0200
 2 files changed, 2 insertions(+), 2 deletions(-)
 Rebasing (5/12)
 Rebasing (6/12)
 Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Update src/node_sqlite.cc
Co-authored-by: Anna Henningsen <[email protected]>
 PR-URL: #59848
 Reviewed-By: Anna Henningsen <[email protected]>
 Reviewed-By: Zeyu "Alex" Yang <[email protected]>
 Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 8834d16dfc] Update src/node_sqlite.cc
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 02:00:32 2025 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
 Rebasing (7/12)
 Rebasing (8/12)
 Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Update src/node_sqlite.cc
Co-authored-by: Anna Henningsen <[email protected]>
 PR-URL: #59848
 Reviewed-By: Anna Henningsen <[email protected]>
 Reviewed-By: Zeyu "Alex" Yang <[email protected]>
 Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 7afec060ed] Update src/node_sqlite.cc
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 02:00:44 2025 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
 Rebasing (9/12)
 Rebasing (10/12)
 Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 sqlite: fix compilation
PR-URL: #59848
 Reviewed-By: Anna Henningsen <[email protected]>
 Reviewed-By: Zeyu "Alex" Yang <[email protected]>
 Reviewed-By: Edy Silva <[email protected]>
[detached HEAD c917470917] sqlite: fix compilation
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 02:23:30 2025 +0200
 1 file changed, 3 insertions(+), 2 deletions(-)
 Rebasing (11/12)
 Rebasing (12/12)
 Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 sqlite: run formatter
PR-URL: #59848
 Reviewed-By: Anna Henningsen <[email protected]>
 Reviewed-By: Zeyu "Alex" Yang <[email protected]>
 Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 0d015e209c] sqlite: run formatter
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 10:55:33 2025 +0200
 1 file changed, 8 insertions(+), 6 deletions(-)
 Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/17944566022

[nodejs-github-bot]

Landed in d2ff9da