http: improve writeEarlyHints by avoiding for-of loop#59958
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 21, 2025
Review requested:
|
nodejs-github-bot added http 
haramjforce-pushed the haramjeong-patch-250921 branch from 0760cdf to 17e98e7Compareharamj changed the title 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #59958 +/- ## ======================================= Coverage 88.42% 88.43% ======================================= Files 703 703 Lines 207399 207401 +2 Branches 39986 39992 +6 ======================================= + Hits 183397 183410 +13 - Misses 15989 15990 +1 + Partials 8013 8001 -12
🚀 New features to boost your workflow:
|
daeyeon approved these changes Sep 27, 2025
daeyeon added request-ci 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 27, 2025
aduh95 approved these changes Sep 28, 2025
Collaborator
nodejs-github-bot commented Sep 28, 2025
MemberAuthor
haramj commented Oct 2, 2025
It looks like the CI run for this PR failed due to a flaky test. |
Collaborator
nodejs-github-bot commented Oct 2, 2025
daeyeon added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit 5b3c4b3 into nodejs:main 64 of 65 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Oct 6, 2025
Landed in 5b3c4b3 |
targos pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #59958 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
PR-URL: #59958 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is based on the "Unsafe array iteration" principle from the Node.js core development guidelines. for-of loops rely on the Symbol.iterator property, which can be modified by userland code, potentially leading to unpredictable or insecure behavior. Using a standard for loop directly accesses the array elements by index, ensuring a more stable and secure execution flow.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration