Skip to content

Conversation

@iknoom
Copy link
Contributor

@iknoomiknoom commented Sep 25, 2025

This PR removes AnalyzeTemporaryDtors option from .clang-tidy. This option was deprecated since clang-tidy 16 and removed in clang-tidy 18.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 25, 2025
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@gurgundaygurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

addaleax pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #60008 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@addaleax
Copy link
Member

Landed in 81b7119

@addaleaxaddaleax closed this Oct 6, 2025
targos pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #60008 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
PR-URL: #60008 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@iknoom@nodejs-github-bot@addaleax@lpinca@anonrig@gurgunday