Skip to content

Conversation

@legendecas
Copy link
Member

Improve batch diagnostic channel subscriptions in network inspections. This could prevent a channel from mismatches in subscribe/unsubscribe.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-botnodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Sep 25, 2025
@codecov
Copy link

codecovbot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.47%. Comparing base (4dc19ec) to head (713dff3).
⚠️ Report is 97 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60009 +/- ## ========================================== - Coverage 88.49% 88.47% -0.02%  ========================================== Files 703 703 Lines 207529 207529 Branches 40011 40015 +4 ========================================== - Hits 183643 183617 -26 - Misses 15885 15899 +14 - Partials 8001 8013 +12 
Files with missing linesCoverage Δ
lib/internal/inspector/network.js95.95% <100.00%> (+1.22%)⬆️
lib/internal/inspector/network_http.js94.85% <100.00%> (-0.39%)⬇️
lib/internal/inspector/network_http2.js94.94% <100.00%> (-0.32%)⬇️
lib/internal/inspector/network_undici.js91.66% <100.00%> (-0.53%)⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2025
@nodejs-github-botnodejs-github-bot merged commit d9b8a35 into nodejs:mainOct 6, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d9b8a35

@legendecaslegendecas deleted the inspector-register branch October 6, 2025 13:50
RafaelGSS pushed a commit that referenced this pull request Oct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2Issues or PRs related to the http2 subsystem.inspectorIssues and PRs related to the V8 inspector protocolneeds-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@legendecas@nodejs-github-bot@lpinca@cjihrig