Skip to content

Conversation

@iknoom
Copy link
Contributor

This PR removes unused variables in node_report.cc detected by clang-tidy(bugprone-unused-local-non-trivial-variable).

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. labels Sep 28, 2025
@codecov
Copy link

codecovbot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (cff138c) to head (bb421bb).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60047 +/- ## ======================================= Coverage 88.45% 88.46% ======================================= Files 703 703 Lines 207546 207544 -2 Branches 40016 40011 -5 ======================================= + Hits 183595 183598 +3 + Misses 15956 15942 -14 - Partials 7995 8004 +9 
Files with missing linesCoverage Δ
src/node_report.cc93.14% <ø> (-0.03%)⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theanarkhtheanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@addaleaxaddaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-botnodejs-github-bot merged commit 36b1cc2 into nodejs:mainOct 2, 2025
81 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 36b1cc2

targos pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #60047 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
PR-URL: #60047 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.reportIssues and PRs related to process.report.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@iknoom@nodejs-github-bot@addaleax@lpinca@cjihrig@legendecas@theanarkh