src: update contextify to use DictionaryTemplate#60059
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
addaleax approved these changes Sep 28, 2025
github-actionsbot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
BridgeAR added author ready 
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jasnellforce-pushed the jasnell/contextify-dictionarytemplate branch from 67a08e7 to 956b245Compare This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
jasnellforce-pushed the jasnell/contextify-dictionarytemplate branch from 956b245 to fa77052CompareCollaborator
nodejs-github-bot commented Oct 5, 2025
legendecas requested changes Oct 5, 2025
Member
legendecas left a comment
legendecas left a comment There was a problem hiding this comment.
It is not convincing that a 20-line if-condition is more readable than simple early returns. I don't believe this beneficial change has to be bundled with a subjective style change.
jasnellforce-pushed the jasnell/contextify-dictionarytemplate branch from fa77052 to 23601daCompare
jasnellforce-pushed the jasnell/contextify-dictionarytemplate branch from 23601da to b53b4ecCompare
MemberAuthor
jasnell commented Oct 5, 2025
Blocking an otherwise fully correct PR for a purely subjective style change seems more counterproductive, especially when the style change is consistent with lots of other places throughout the codebase, but ok. I switched it back to the multiple separate if statements. |
addaleax approved these changes Oct 5, 2025
Collaborator
nodejs-github-bot commented Oct 6, 2025
tniessen approved these changes Oct 6, 2025
addaleax added commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit 4a7fbb6 into nodejs:main 60 of 61 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Oct 6, 2025
Landed in 4a7fbb6 |
targos pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #60059 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More use of DictionaryTemplate