Skip to content

test: deflake test-fs-promises-watch-iterator#60060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 9, 2025
Merged

test: deflake test-fs-promises-watch-iterator #60060

nodejs-github-bot merged 1 commit into from
Oct 9, 2025
+3 −1

Conversation

@lpinca
Copy link
Member

@lpincalpinca commented Sep 28, 2025

Add a delay before writing the files to ensure that the watcher receives the notifications.

Fixes: #60051
Refs: #52601

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2025
lpinca
lpinca commented Sep 28, 2025
View reviewed changes
test/parallel/test-fs-promises-watch-iterator.js
for(constfileNameof[...this.files]){
awaitwriteFile(this.filePath(fileName),Date.now()+fileName.repeat(1e4));
}
awaitsetTimeout(common.platformTimeout(100));
Copy link
MemberAuthor

@lpincalpincaSep 28, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there was a reason for this I will add it back, but I don't see it.

lpinca
lpinca commented Sep 28, 2025
View reviewed changes
test/parallel/test-fs-promises-watch-iterator.js
Comment on lines +37 to +38
// Do the write with a delay to ensure that the OS is ready to notify us.
awaitsetTimeout(common.platformTimeout(100));
Copy link
MemberAuthor

@lpincalpincaSep 28, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is done in other fs.watch() tests, for example:

node/test/parallel/test-fs-watch-recursive-add-file.js

Lines 41 to 44 in c6316f9

// Do the write with a delay to ensure that the OS is ready to notify us.
setTimeout(()=>{
fs.writeFileSync(testFile,'world');
},common.platformTimeout(200));

Copy link
Member

@anonriganonrigOct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves a TODO to investigate why this is occuring and whether or not this is a bug.

Copy link
MemberAuthor

@lpincalpincaOct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already an open issue (#52601) linked in the commit message.

gurgunday
gurgunday approved these changes Sep 28, 2025
View reviewed changes
Copy link
Member

@gurgundaygurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

lgtm

@codecov
Copy link

codecovbot commented Sep 28, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (6f941fc) to head (dfdbb39).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60060 +/- ## ========================================== - Coverage 88.45% 88.45% -0.01%  ========================================== Files 703 703 Lines 207826 207826 Branches 40030 40038 +8 ========================================== - Hits 183842 183826 -16 + Misses 15973 15972 -1 - Partials 8011 8028 +17

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@gurgundaygurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@lpinca
test: deflake test-fs-promises-watch-iterator
dfdbb39
Add a delay before writing the files to ensure that the watcher receives the notifications. Fixes: nodejs#60051 Refs: nodejs#52601
@lpincalpincaforce-pushed the deflake/test-fs-promises-watch-iterator branch from d3b5d31 to dfdbb39CompareOctober 4, 2025 10:13
@lpinca
Copy link
MemberAuthor

lpinca commented Oct 4, 2025

Rebased, this needs new approvals.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69559/

@lpincalpinca added the review wanted PRs that need reviews. label Oct 8, 2025
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-botnodejs-github-bot merged commit f8a43f6 into nodejs:mainOct 9, 2025
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2025

Landed in f8a43f6

@lpincalpinca deleted the deflake/test-fs-promises-watch-iterator branch October 9, 2025 05:38
@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
@lpinca@aduh95
test: deflake test-fs-promises-watch-iterator
c88ea78
Add a delay before writing the files to ensure that the watcher receives the notifications. Fixes: #60051 Refs: #52601 PR-URL: #60060 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
@lpinca@aduh95
test: deflake test-fs-promises-watch-iterator
cc3a705
Add a delay before writing the files to ensure that the watcher receives the notifications. Fixes: #60051 Refs: #52601 PR-URL: #60060 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig left review comments

@addaleaxaddaleaxaddaleax approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

@gurgundaygurgundaygurgunday approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.review wantedPRs that need reviews.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel/test-fs-promises-watch-iterator is flaky

6 participants

@lpinca@nodejs-github-bot@addaleax@anonrig@joyeecheung@gurgunday