Skip to content

Conversation

@joyeecheung
Copy link
Member

Original commit message:

[flags] Ignore memory tuning flags when computing hash for code caching Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Joyee Cheung <[email protected]> Cr-Commit-Position: refs/heads/main@{#102443} 

Refs: v8/v8@8735658

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 29, 2025
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Original commit message: [flags] Ignore memory tuning flags when computing hash for code caching Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Joyee Cheung <[email protected]> Cr-Commit-Position: refs/heads/main@{#102443} Refs: v8/v8@8735658
@joyeecheungjoyeecheungforce-pushed the backport-memory-tuning branch from afbb6e4 to ad03400CompareOctober 8, 2025 13:08
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
@nodejs-github-botnodejs-github-bot merged commit 4eb6e6f into nodejs:mainOct 8, 2025
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4eb6e6f

@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
9 tasks
targos pushed a commit that referenced this pull request Nov 18, 2025
Original commit message: [flags] Ignore memory tuning flags when computing hash for code caching Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Joyee Cheung <[email protected]> Cr-Commit-Position: refs/heads/main@{#102443} Refs: v8/v8@8735658 PR-URL: #60069 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung@nodejs-github-bot@addaleax@targos@richardlau@legendecas@RafaelGSS