Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
perf_hooks: fix stack overflow error#60084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
codecovbot commented Oct 1, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #60084 +/- ## ========================================== + Coverage 88.43% 88.45% +0.01% ========================================== Files 703 703 Lines 207795 207819 +24 Branches 40022 40029 +7 ========================================== + Hits 183767 183824 +57 + Misses 16021 15976 -45 - Partials 8007 8019 +12
🚀 New features to boost your workflow:
|
| */ | ||
| primordials.SafeArrayPrototypePushApply=(arr,items)=>{ | ||
| letstart=0; | ||
| letend=start+0x1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason not to make this just end = 4096?
| letend=start+0x1000; | ||
| while(end<items.length){ | ||
| ArrayPrototypePushApply(arr,ArrayPrototypeSlice(items,start,start=end)); | ||
| end+=0x1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the code may be more readable if 4096 was used instead of hex.
nodejs-github-bot commented Oct 12, 2025 • edited by aduh95
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by aduh95
Uh oh!
There was an error while loading. Please reload this page.
CI: https://ci.nodejs.org/job/node-test-pull-request/69700/ No noticeable perf diff |
822a8c3 into nodejs:mainUh oh!
There was an error while loading. Please reload this page.
aduh95 commented Oct 13, 2025
Landed in 822a8c3 |
PR-URL: #60084Fixes: #54768 Reviewed-By: Colin Ihrig <[email protected]>
Alternative to #54772, as suggested by #54772 (comment)