test: mark test-runner-run-watch flaky on macOS#60115
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`parallel/test-runner-run-watch` has failed 33 out of the last 100 CI runs on macOS. It is already marked flaky on other platforms.
richardlau added test 
cjihrig approved these changes Oct 3, 2025
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #60115 +/- ## ========================================== + Coverage 88.43% 88.46% +0.02% ========================================== Files 703 703 Lines 207805 207805 Branches 40026 40028 +2 ========================================== + Hits 183780 183830 +50 + Misses 16012 15962 -50 Partials 8013 8013 🚀 New features to boost your workflow:
|
Collaborator
nodejs-github-bot commented Oct 3, 2025
Collaborator
nodejs-github-bot commented Oct 4, 2025
richardlau added the author ready 
lpinca approved these changes Oct 5, 2025
lpinca added the commit-queue 
nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit 7c85aa5 into nodejs:main 81 of 82 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Oct 5, 2025
Landed in 7c85aa5 |
targos pushed a commit that referenced this pull request Oct 6, 2025
`parallel/test-runner-run-watch` has failed 33 out of the last 100 CI runs on macOS. It is already marked flaky on other platforms. PR-URL: #60115 Refs: #54534 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
joyeecheung commented Oct 22, 2025
FWIW I noticed that this test also contains a lot of test cases. We should probably split it up and only mark the persistent flakes as flaky to avoid masking regressions. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parallel/test-runner-run-watchhas failed 33 out of the last 100 CI runs on macOS. It is already marked flaky on other platforms.Refs: #54534