Skip to content

http2: do not crash on mismatched ping buffer length#60135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 8, 2025
Merged

http2: do not crash on mismatched ping buffer length #60135

nodejs-github-bot merged 1 commit into from
Oct 8, 2025

Conversation

@Renegade334
Copy link
Member

@Renegade334Renegade334 commented Oct 6, 2025

constsession=require('http2').connect('http://localhost/')session.ping(newUint32Array(8),console.debug)

yields

 # node[1898056]: static void node::http2::Http2Session::Ping(const v8::FunctionCallbackInfo<v8::Value>&) at ../src/node_http2.cc:3227 # Assertion failed: (payload.length()) == (8) IOT instruction (core dumped)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 6, 2025

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 6, 2025
@codecov
Copy link

codecovbot commented Oct 7, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (b757a8f) to head (b0a2c8c).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60135 +/- ## ========================================== - Coverage 88.53% 88.52% -0.02%  ========================================== Files 703 703 Lines 207804 207804 Branches 40005 40006 +1 ========================================== - Hits 183989 183952 -37 - Misses 15817 15866 +49 + Partials 7998 7986 -12
Files with missing linesCoverage Δ
lib/internal/http2/core.js95.20% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeARBridgeAR added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 7, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69586/

mcollina
mcollina approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2025
@mcollinamcollina added lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x and removed request-ci Add this label to start a Jenkins CI on a PR. needs-ci PRs that need a full CI run. labels Oct 7, 2025
@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
@nodejs-github-botnodejs-github-bot merged commit 535efea into nodejs:mainOct 8, 2025
85 of 86 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 8, 2025

Landed in 535efea

@Renegade334Renegade334 deleted the http2-ping-byte-length branch October 9, 2025 05:12
@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
@Renegade334@aduh95
http2: do not crash on mismatched ping buffer length
5009021
PR-URL: #60135 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
@Renegade334@aduh95
http2: do not crash on mismatched ping buffer length
65bec03
PR-URL: #60135 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Merged
@marco-ippolitomarco-ippolito removed the lts-watch-v20.x PRs that may need to be released in v20.x label Nov 19, 2025
marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
@Renegade334@marco-ippolito
http2: do not crash on mismatched ping buffer length
20616f1
PR-URL: #60135 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolitomarco-ippolito mentioned this pull request Nov 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@lpincalpincalpinca approved these changes

@pimterrypimterrypimterry approved these changes

@cjihrigcjihrigcjihrig approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@RafaelGSSRafaelGSSRafaelGSS approved these changes

@gurgundaygurgundaygurgunday approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.lts-watch-v22.xPRs that may need to be released in v22.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@Renegade334@nodejs-github-bot@mcollina@lpinca@pimterry@cjihrig@BridgeAR@RafaelGSS@gurgunday@richardlau@marco-ippolito