test: make use of globals explicit#6014
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use `global` to be explicit that a global variable is intended.
Trott added vm 
Member
jasnell commented Apr 2, 2016
LGTM |
1 similar comment
Contributor
cjihrig commented Apr 2, 2016
LGTM |
Member
jasnell commented Apr 4, 2016
Trott added a commit to Trott/io.js that referenced this pull request Apr 5, 2016
Use `global` to be explicit that a global variable is intended. PR-URL: nodejs#6014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
Trott commented Apr 5, 2016
Landed in d416a59 |
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
Use `global` to be explicit that a global variable is intended. PR-URL: #6014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
Use `global` to be explicit that a global variable is intended. PR-URL: #6014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
test vm
Description of change
Use
globalto be explicit that a global variable is intended.