Skip to content

lib: fix typo in QuicSessionStats#60155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 10, 2025
Merged

lib: fix typo in QuicSessionStats #60155

nodejs-github-bot merged 1 commit into from
Oct 10, 2025

Conversation

@SeokhunEom
Copy link
Contributor

@SeokhunEomSeokhunEom commented Oct 8, 2025

Corrects the misspelling of "privateSynbol" to "privateSymbol".

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Oct 8, 2025
@codecov
Copy link

codecovbot commented Oct 8, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (535efea) to head (17d993a).
⚠️ Report is 7 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/quic/stats.js66.66%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #60155 +/- ## ========================================== - Coverage 88.55% 88.53% -0.03%  ========================================== Files 704 704 Lines 208081 208081 Branches 40011 40010 -1 ========================================== - Hits 184270 184220 -50 - Misses 15826 15867 +41 - Partials 7985 7994 +9
Files with missing linesCoverage Δ
lib/internal/quic/stats.js95.31% <66.66%> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SeokhunEomSeokhunEom mentioned this pull request Oct 8, 2025
Closed
@Hritikk999
Copy link

Hritikk999 commented Oct 8, 2025

1 Failed, 20 successful checks

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@SeokhunEom
lib: fix typo in QuicSessionStats
17d993a
Corrects the misspelling of "privateSynbol" to "privateSymbol".
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69634/

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2025
@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2025
@nodejs-github-botnodejs-github-bot merged commit 4daeec1 into nodejs:mainOct 10, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2025

Landed in 4daeec1

@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
@SeokhunEom@aduh95
lib: fix typo in QuicSessionStats
caafda2
Corrects the misspelling of "privateSynbol" to "privateSymbol". PR-URL: #60155 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
@SeokhunEom@aduh95
lib: fix typo in QuicSessionStats
4f7745a
Corrects the misspelling of "privateSynbol" to "privateSymbol". PR-URL: #60155 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SeokhunEom@Hritikk999@nodejs-github-bot@jasnell@lpinca@richardlau