Skip to content

lib: fix constructor in _errnoException stack tree#60156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 13, 2025
Merged

lib: fix constructor in _errnoException stack tree #60156

nodejs-github-bot merged 1 commit into from
Oct 13, 2025

Conversation

@SeokhunEom
Copy link
Contributor

@SeokhunEomSeokhunEom commented Oct 8, 2025

Fixes the constructor name in the stack tree for _errnoException.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Oct 8, 2025
@SeokhunEom
lib: fix constructor in _errnoException stack tree
9045847
Fixes the constructor name in the stack tree for _errnoException.
@SeokhunEomSeokhunEomforce-pushed the fix-errnoException-stacktree branch from ac46097 to 9045847CompareOctober 8, 2025 04:36
@SeokhunEomSeokhunEom changed the title lib: fix constructor in errnoException stack treelib: fix constructor in _errnoException stack treeOct 8, 2025
@codecov
Copy link

codecovbot commented Oct 8, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (b13f24c) to head (9045847).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60156 +/- ## ======================================= Coverage 88.53% 88.54% ======================================= Files 703 703 Lines 207997 207997 Branches 40015 40020 +5 ======================================= + Hits 184150 184167 +17 + Misses 15864 15854 -10 + Partials 7983 7976 -7
Files with missing linesCoverage Δ
lib/util.js97.95% <100.00%> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daeyeondaeyeon added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 9, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69645/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69651/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69684/

@daeyeondaeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2025
@nodejs-github-botnodejs-github-bot merged commit 4bfa387 into nodejs:mainOct 13, 2025
64 of 65 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2025

Landed in 4bfa387

@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
@SeokhunEom@aduh95
lib: fix constructor in _errnoException stack tree
0c130d0
Fixes the constructor name in the stack tree for _errnoException. PR-URL: #60156 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
@SeokhunEom@aduh95
lib: fix constructor in _errnoException stack tree
5aea1a4
Fixes the constructor name in the stack tree for _errnoException. PR-URL: #60156 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daeyeondaeyeondaeyeon approved these changes

@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SeokhunEom@nodejs-github-bot@daeyeon@legendecas