deps: V8: cherry-pick 2abc61361dd4#60177
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original commit message: Fix scratch registers passed to mtvsrdd `ra` cannot be r0 as it will be interpreted as Operand(0) Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113 Commit-Queue: Milad Farazmand <[email protected]> Reviewed-by: Junliang Yan <[email protected]> Cr-Commit-Position: refs/heads/main@{#102388} Refs: v8/v8@2abc613
richardlau added v8 engine 
Collaborator
nodejs-github-bot commented Oct 9, 2025
Review requested:
|
nodejs-github-bot added build 
cjihrig approved these changes Oct 9, 2025
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Oct 9, 2025
Collaborator
nodejs-github-bot commented Oct 9, 2025
Collaborator
nodejs-github-bot commented Oct 9, 2025
targos approved these changes Oct 9, 2025
Collaborator
nodejs-github-bot commented Oct 10, 2025
Collaborator
nodejs-github-bot commented Oct 10, 2025
Collaborator
nodejs-github-bot commented Oct 10, 2025
Collaborator
nodejs-github-bot commented Oct 10, 2025
richardlau added commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot merged commit a1b73fe into nodejs:main 83 of 84 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented Oct 11, 2025
Landed in a1b73fe |
9 tasks
richardlau added a commit that referenced this pull request Nov 7, 2025
Original commit message: Fix scratch registers passed to mtvsrdd `ra` cannot be r0 as it will be interpreted as Operand(0) Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113 Commit-Queue: Milad Farazmand <[email protected]> Reviewed-by: Junliang Yan <[email protected]> Cr-Commit-Position: refs/heads/main@{#102388} Refs: v8/v8@2abc613 PR-URL: #60177 Refs: nodejs/undici#4530 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 11, 2025
Original commit message: Fix scratch registers passed to mtvsrdd `ra` cannot be r0 as it will be interpreted as Operand(0) Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113 Commit-Queue: Milad Farazmand <[email protected]> Reviewed-by: Junliang Yan <[email protected]> Cr-Commit-Position: refs/heads/main@{#102388} Refs: v8/v8@2abc613 PR-URL: #60177 Refs: nodejs/undici#4530 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@2abc613
Refs: #59605 (comment)
Refs: nodejs/undici#4530
It turned out that nodejs/llparse#73 / undici 7.15.0 uncovered a bug on Power which has been addressed by this cherry-pick. It will unblock re-enabling SIMD in undici on Power (i.e. partially undoing nodejs/undici#4530).