Skip to content

http2: rename variable to additionalPseudoHeaders#60208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 13, 2025
Merged

http2: rename variable to additionalPseudoHeaders #60208

nodejs-github-bot merged 1 commit into from
Oct 13, 2025

Conversation

@tniessen
Copy link
Member

@tniessentniessen commented Oct 11, 2025

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2025

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 11, 2025
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69679/

@codecov
Copy link

codecovbot commented Oct 11, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (e105e82) to head (e018a81).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60208 +/- ## ========================================== + Coverage 88.53% 88.54% +0.01%  ========================================== Files 704 704 Lines 208087 208087 Branches 40006 40012 +6 ========================================== + Hits 184223 184248 +25 + Misses 15869 15854 -15 + Partials 7995 7985 -10
Files with missing linesCoverage Δ
lib/internal/http2/util.js92.69% <100.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daeyeondaeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 11, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69680/

mcollina
mcollina approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2025
@nodejs-github-botnodejs-github-bot merged commit 5cf3c3e into nodejs:mainOct 13, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2025

Landed in 5cf3c3e

@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
@tniessen@aduh95
http2: rename variable to additionalPseudoHeaders
cc2d9fd
PR-URL: #60208 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tim Perry <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
@tniessen@aduh95
http2: rename variable to additionalPseudoHeaders
265e9d5
PR-URL: #60208 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tim Perry <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Nov 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@lpincalpincalpinca approved these changes

@pimterrypimterrypimterry approved these changes

@cjihrigcjihrigcjihrig approved these changes

@richardlaurichardlaurichardlau approved these changes

@daeyeondaeyeondaeyeon approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@tniessen@nodejs-github-bot@mcollina@lpinca@pimterry@cjihrig@richardlau@daeyeon@RaisinTen@bjohansebas