Skip to content

sqlite: make SQLTagStore.prototype.size a getter#60246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 11, 2025
Merged

sqlite: make SQLTagStore.prototype.size a getter #60246

nodejs-github-bot merged 1 commit into from
Dec 11, 2025

Conversation

@Renegade334
Copy link
Member

@Renegade334Renegade334 commented Oct 13, 2025•
edited
Loading

As implemented, .db and .capacity are getters, and .size is a callable method. There's no reason for this inconsistency, so change .size to a getter.

Drive-by changes while making alterations to the class template: the FunctionCallbackInfo parameter for SQLTagStore member functions was variably labelled args or info, and wasn't consistent with the header either. Use the canonical args.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2025

Review requested:

  • @nodejs/sqlite

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Oct 13, 2025
cjihrig
cjihrig approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@cjihrigcjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but all of the stylistic changes should really be made separately.

@Renegade334Renegade334force-pushed the sqlite-tagstore-size-getter branch from dabca78 to 3142319CompareOctober 13, 2025 15:23
@Renegade334
Copy link
MemberAuthor

Renegade334 commented Oct 13, 2025•
edited
Loading

LGTM, but all of the stylistic changes should really be made separately.

I'm already half-addressing them de facto with the main change, but these can be spun out if desired.

Edit: Spun out the other doc changes.

@codecov
Copy link

codecovbot commented Oct 13, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.56%. Comparing base (0b6ae6d) to head (4a16146).
⚠️ Report is 141 commits behind head on main.

Files with missing linesPatch %Lines
src/node_sqlite.cc80.95%0 Missing and 4 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #60246 +/- ## ========================================== + Coverage 88.04% 88.56% +0.51%  ========================================== Files 703 703 Lines 208260 208259 -1 Branches 40068 40160 +92 ========================================== + Hits 183360 184438 +1078 + Misses 16840 15841 -999 + Partials 8060 7980 -80
Files with missing linesCoverage Δ
src/node_sqlite.h80.39% <ø> (ø)
src/node_sqlite.cc79.92% <80.95%> (-0.01%)⬇️

... and 101 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334Renegade334force-pushed the sqlite-tagstore-size-getter branch 2 times, most recently from ff66727 to a2eaaa0CompareOctober 13, 2025 20:18
@Renegade334Renegade334force-pushed the sqlite-tagstore-size-getter branch from a2eaaa0 to a217a01CompareOctober 31, 2025 13:53
@Renegade334Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 14, 2025
@Renegade334
sqlite: make SQLTagStore.prototype.size a getter
4a16146
Drive-by: make callback `args` parameter names consistent
@Renegade334Renegade334force-pushed the sqlite-tagstore-size-getter branch from a217a01 to 4a16146CompareNovember 18, 2025 14:05
@Renegade334
Copy link
MemberAuthor

Renegade334 commented Nov 18, 2025

Rebased for merge conflict.

cjihrig
cjihrig approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@cjihrigcjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the info to args renaming makes the diff more involved than it should be for this PR.

@Renegade334Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70242/

@Renegade334Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2025
@nodejs-github-botnodejs-github-bot merged commit a1f421f into nodejs:mainDec 11, 2025
77 of 84 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 11, 2025

Landed in a1f421f

aduh95 pushed a commit that referenced this pull request Jan 9, 2026
@Renegade334@aduh95
sqlite: make SQLTagStore.prototype.size a getter
9072527
Drive-by: make callback `args` parameter names consistent PR-URL: #60246 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Jan 12, 2026
@Renegade334@aduh95
sqlite: make SQLTagStore.prototype.size a getter
d702831
Drive-by: make callback `args` parameter names consistent PR-URL: #60246 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@louwerslouwerslouwers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Renegade334@nodejs-github-bot@louwers@anonrig@cjihrig