test: ensure win32.isAbsolute() is consistent#6043
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adds test cases to ensure win32.isAbsolute is consistent. This is a backport from 3072546 ref: nodejs#6028
mscdex added test ContributorAuthor
MylesBorins commented Apr 4, 2016
ContributorAuthor
MylesBorins commented Apr 4, 2016
@mscdex I kept you as the author of the commit although I have completely rewritten the commit title / message. Please let me know if you would like anything changed, including your authorship. |
Member
jasnell commented Apr 4, 2016
LGTM if CI is green |
Contributor
mscdex commented Apr 4, 2016
LGTM |
Contributor
silverwind commented Apr 8, 2016
LGTM |
jasnell pushed a commit that referenced this pull request Apr 8, 2016
Adds test cases to ensure win32.isAbsolute is consistent. This is a backport from 3072546 Refs: #6028 PR-URL: #6043 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Member
jasnell commented Apr 8, 2016
Landed in v4.x-staging in ea83c38 |
ContributorAuthor
MylesBorins commented Apr 8, 2016
thanks @jasnell |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test cases to ensure win32.isAbsolute is consistent.
This is a backport from 3072546
ref: #6028