test: enforce strict mode for test-domain-crypto#6047
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The last change to this test landed before a nit about strict mode was addressed, so this change addresses that. Refs: nodejs#6017
Trott added crypto 
Contributor
cjihrig commented Apr 5, 2016
LGTM |
2 similar comments
Member
benjamingr commented Apr 5, 2016
LGTM |
Contributor
r-52 commented Apr 5, 2016
LGTM |
MemberAuthor
Trott commented Apr 5, 2016
Trott added a commit to Trott/io.js that referenced this pull request Apr 6, 2016
The last change to this test landed before a nit about strict mode was addressed, so this change addresses that. PR-URL: nodejs#6047 Refs: nodejs#6017 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MemberAuthor
Trott commented Apr 6, 2016
Landed in d4eafd0 |
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
The last change to this test landed before a nit about strict mode was addressed, so this change addresses that. PR-URL: #6047 Refs: #6017 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
The last change to this test landed before a nit about strict mode was addressed, so this change addresses that. PR-URL: #6047 Refs: #6017 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
The last change to this test landed before a nit about strict mode was addressed, so this change addresses that. PR-URL: #6047 Refs: #6017 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
The last change to this test landed before a nit about strict mode was addressed, so this change addresses that. PR-URL: #6047 Refs: #6017 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
The last change to this test landed before a nit about strict mode was addressed, so this change addresses that. PR-URL: #6047 Refs: #6017 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
crypto domain test
Description of change
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.
Refs: #6017
/cc @bnoordhuis@jasnell