Skip to content

Conversation

@gurgunday
Copy link
Member

As said by the person who put the todo in the first place, it has been redundant for a while now

We have kWeakHandler: this now

PR removes it to prevent confusion

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 5, 2025
@codecov
Copy link

codecovbot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (b4b1413) to head (3673174).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60595 +/- ## ========================================== - Coverage 88.56% 88.54% -0.03%  ========================================== Files 704 704 Lines 208077 208075 -2 Branches 40084 40077 -7 ========================================== - Hits 184289 184233 -56 - Misses 15826 15882 +56 + Partials 7962 7960 -2 
Files with missing linesCoverage Δ
lib/internal/event_target.js99.16% <ø> (-0.01%)⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@gurgunday@lpinca@anonrig@nodejs-github-bot