[v25.x] deps: V8: cherry-pick 72b0e27bd936#60706
Closed
+19 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 13, 2025
Review requested:
|
nodejs-github-bot added build 
targos added the backport-requested-v24.x 
targos approved these changes Nov 13, 2025
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
richardlau commented Nov 14, 2025
You may need to rebase this to pick up 5316b58 to fix the V8 CI. |
MemberAuthor
Renegade334 commented Nov 14, 2025
That answers that mystery 😄 |
Renegade334force-pushed the v25.x-staging branch from daf2707 to 3914b73Compare
Original commit message: [regexp] Fix modifiers for ChoiceNodes Each alternative might modify flags when their sub-graph is emitted. We need to restore flags to the value at the beginning of a ChoiceNode for each alternative. Drive-by: Move regexp-modifiers test out of harmony/ Fixed: 447583670 Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181 Reviewed-by: Jakob Linke <[email protected]> Commit-Queue: Patrick Thier <[email protected]> Cr-Commit-Position: refs/heads/main@{#102838} Refs: v8/v8@72b0e27 Refs: nodejs#60030
Renegade334force-pushed the v25.x-staging branch from 3914b73 to b2a2242Compare
richardlau approved these changes Nov 15, 2025
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Nov 15, 2025
Collaborator
nodejs-github-bot commented Nov 15, 2025
UlisesGascon approved these changes Nov 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Nov 15, 2025
Renegade334 added commit-queue 
Contributor
bricss commented Dec 3, 2025
How we can get this quite important fix 🩹 moving? 🙄 |
RafaelGSS approved these changes Dec 10, 2025
RafaelGSS pushed a commit that referenced this pull request Dec 10, 2025
Original commit message: [regexp] Fix modifiers for ChoiceNodes Each alternative might modify flags when their sub-graph is emitted. We need to restore flags to the value at the beginning of a ChoiceNode for each alternative. Drive-by: Move regexp-modifiers test out of harmony/ Fixed: 447583670 Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181 Reviewed-by: Jakob Linke <[email protected]> Commit-Queue: Patrick Thier <[email protected]> Cr-Commit-Position: refs/heads/main@{#102838} Refs: v8/v8@72b0e27 Refs: #60030 PR-URL: #60706 Backport-PR-URL: #60706
Member
RafaelGSS commented Dec 10, 2025
Landed in 8a3bd6e09aa4 |
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
Original commit message: [regexp] Fix modifiers for ChoiceNodes Each alternative might modify flags when their sub-graph is emitted. We need to restore flags to the value at the beginning of a ChoiceNode for each alternative. Drive-by: Move regexp-modifiers test out of harmony/ Fixed: 447583670 Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181 Reviewed-by: Jakob Linke <[email protected]> Commit-Queue: Patrick Thier <[email protected]> Cr-Commit-Position: refs/heads/main@{#102838} Refs: v8/v8@72b0e27 Refs: #60030 PR-URL: #60706 Backport-PR-URL: #60706
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@72b0e27
Refs: #60030