Skip to content

test: ensure assertions are reached on HTTP2 tests#60730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 1 commit into from
Nov 17, 2025
Merged

test: ensure assertions are reached on HTTP2 tests #60730

aduh95 merged 1 commit into from
Nov 17, 2025

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Nov 15, 2025

Another followup of #60125

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 15, 2025
@codecov
Copy link

codecovbot commented Nov 15, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (4218749) to head (ecbc22d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60730 +/- ## ======================================= Coverage 88.55% 88.55% ======================================= Files 703 703 Lines 208257 208257 Branches 40160 40168 +8 ======================================= + Hits 184417 184424 +7 - Misses 15837 15868 +31 + Partials 8003 7965 -38

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax
addaleax approved these changes Nov 16, 2025
View reviewed changes
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 16, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 16, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70195/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 16, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70201/

@aduh95
test: ensure assertions are reached on HTTP2 tests
ecbc22d
PR-URL: nodejs#60730 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@aduh95aduh95force-pushed the must-call-mustCalls-http2 branch from 558983e to ecbc22dCompareNovember 17, 2025 20:35
@aduh95
Copy link
ContributorAuthor

aduh95 commented Nov 17, 2025

Landed in ecbc22d

@aduh95aduh95 merged commit ecbc22d into nodejs:mainNov 17, 2025
20 of 21 checks passed
@aduh95aduh95 deleted the must-call-mustCalls-http2 branch November 17, 2025 20:35
targos pushed a commit that referenced this pull request Nov 27, 2025
@aduh95@targos
test: ensure assertions are reached on HTTP2 tests
d9bc0bf
PR-URL: #60730 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@addaleax@cjihrig