Skip to content

test: ensure assertions are reached on more tests#60760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Nov 24, 2025
Merged

test: ensure assertions are reached on more tests #60760

nodejs-github-bot merged 1 commit into from
Nov 24, 2025

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Nov 17, 2025

Another followup of #60125

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2025

Review requested:

  • @nodejs/sqlite

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 17, 2025
@codecov
Copy link

codecovbot commented Nov 17, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (17fba60) to head (864470d).
⚠️ Report is 50 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60760 +/- ## ========================================== - Coverage 88.57% 88.55% -0.03%  ========================================== Files 703 703 Lines 208256 208256 Branches 40158 40156 -2 ========================================== - Hits 184469 184419 -50 - Misses 15824 15833 +9 - Partials 7963 8004 +41

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 18, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 18, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70230/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2025
@nodejs-github-botnodejs-github-bot merged commit 411ce7e into nodejs:mainNov 24, 2025
83 of 84 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 24, 2025

Landed in 411ce7e

@aduh95aduh95 deleted the must-call-mustCalls-s branch November 24, 2025 22:45
targos pushed a commit that referenced this pull request Nov 27, 2025
@aduh95@targos
test: ensure assertions are reached on more tests
487f9be
PR-URL: #60760 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95@nodejs-github-bot@cjihrig