test: move some test from sequential to parallel#6087
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
claudiorodriguez commented Apr 6, 2016
MemberAuthor
santigimeno commented Apr 6, 2016
/cc @nodejs/testing |
Contributor
cjihrig commented Apr 7, 2016
LGTM and CI is green. |
Member
jbergstroem commented Apr 7, 2016
@santigimeno: can you run these tests with |
Member
jbergstroem commented Apr 7, 2016
Disregard that. |
Member
jbergstroem commented Apr 7, 2016
LGTM |
Contributor
There was a problem hiding this comment.
The path has to be updated.
Member
jasnell commented Apr 7, 2016
LGTM with nits addressed |
santigimenoforce-pushed the from_seq_to_parallel branch from 0d8a8a7 to c085ef1CompareMemberAuthor
santigimeno commented Apr 7, 2016
PR updated. Thanks! |
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked.
Member
jasnell commented Apr 8, 2016
New CI after update: https://ci.nodejs.org/job/node-test-pull-request/2221/ |
Contributor
thefourtheye commented Apr 8, 2016
LGTM if CI is green. |
Contributor
claudiorodriguez commented Apr 8, 2016
CI green. LGTM |
jasnell pushed a commit that referenced this pull request Apr 9, 2016
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: #6087 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
Member
jasnell commented Apr 9, 2016
Landed in eaab17c |
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: #6087 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: #6087 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: #6087 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: #6087 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: #6087 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: #6087 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
The only test with modifications is
test-stdin-child-procthat waspassing when it should not because the exit code of the child process
was not being checked.
I have run the tests on
Debian Jessie 64andSmartOSand pass on both.