Skip to content

test: lint more assert(regexp.test(...)) cases#60878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Nov 30, 2025
Merged

test: lint more assert(regexp.test(...)) cases #60878

nodejs-github-bot merged 2 commits into from
Nov 30, 2025

Conversation

@Renegade334
Copy link
Member

@Renegade334Renegade334 commented Nov 27, 2025

Widens the net to include plain old assert().

Refs: #60832

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 27, 2025

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 27, 2025
@codecov
Copy link

codecovbot commented Nov 28, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (08d966c) to head (8d7cc47).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60878 +/- ## ========================================== - Coverage 88.54% 88.54% -0.01%  ========================================== Files 703 703 Lines 208291 208291 Branches 40170 40166 -4 ========================================== - Hits 184430 184425 -5 - Misses 15865 15874 +9 + Partials 7996 7992 -4

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70334/

aduh95
aduh95 reviewed Nov 28, 2025
View reviewed changes
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 29, 2025
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70347/

@Renegade334Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2025
@nodejs-github-botnodejs-github-bot merged commit 209a4fe into nodejs:mainNov 30, 2025
70 of 73 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2025

Landed in 209a4fe

targos pushed a commit that referenced this pull request Dec 5, 2025
@Renegade334@targos
test: lint more assert(regexp.test(...)) cases
2c005a8
PR-URL: #60878 Refs: #60832 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Renegade334@nodejs-github-bot@lpinca@cjihrig@aduh95