events: don't inherit from Object.prototype#6092
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added events mscdexforce-pushed the events-empty-prototype branch from 8680b06 to 2cec8a1Compare
ContributorAuthor
mscdex commented Apr 7, 2016
ContributorAuthor
mscdex commented Apr 7, 2016
Also, there is no performance regression with this change 💃 |
Contributor
thefourtheye commented Apr 7, 2016
Can we make use of the test changes in #2350? |
ContributorAuthor
mscdex commented Apr 7, 2016
@thefourtheye The included tests should cover it I think |
Contributor
evanlucas commented Apr 7, 2016
@mscdex will this have any affect on |
Contributor
vkurchatkin commented Apr 7, 2016
@evanlucas it makes sense to simply call |
mscdexforce-pushed the events-empty-prototype branch from 2cec8a1 to 3711c52CompareContributorAuthor
mscdex commented Apr 7, 2016
@evanlucas Fixed. CI again: https://ci.nodejs.org/job/node-test-pull-request/2196/ |
Contributor
evanlucas commented Apr 7, 2016
LGTM |
src/node.cc Outdated
Contributor
Fishrock123 commented Apr 7, 2016
Hmmm, can this be back-ported? Theoretically, this could be considered a security issue for unvalidated input. |
3 tasks
ContributorAuthor
mscdex commented Apr 7, 2016
@Fishrock123 It's definitely a semver-major change, but I don't recall how that plays out with backporting/LTS/etc. |
3 tasks
ContributorAuthor
mscdex commented Apr 7, 2016
Member
jasnell commented Apr 7, 2016
I don't believe back porting would be possible to v4. It might be safe to get into v5 tho. |
Member
jasnell commented Apr 7, 2016
LGTM |
ContributorAuthor
mscdex commented Apr 7, 2016
CI is green except for a flaky test and citgm is green. |
ContributorAuthor
mscdex commented Apr 18, 2016
CI again one last time: https://ci.nodejs.org/job/node-test-pull-request/2305/ |
Member
jasnell commented Apr 18, 2016
Still LGTM |
This commit safely allows event names that are named the same as properties that are ordinarily inherited from Object.prototype such as __proto__. Fixes: nodejs#728 PR-URL: nodejs#6092 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
mscdexforce-pushed the events-empty-prototype branch from 3711c52 to e38badeCompareContributor
Fishrock123 commented Apr 19, 2016
iirc usually we don't care about warnings |
Member
jasnell commented Apr 19, 2016
Typically, but it's nice to avoid them when possible to do so, no? |
Contributor
I guess, just consider though, that there are tons of warnings of the same and there isn't necessarily easy ways to avoid it. |
2 tasks
thefourtheye added a commit to thefourtheye/io.js that referenced this pull request Apr 19, 2016
This patch fixes the warning introduced by the changes in e38bade. Ref: nodejs#6092
thefourtheye added a commit that referenced this pull request Apr 19, 2016
This patch fixes the warning introduced by the changes in e38bade. Ref: #6092 PR-URL: #6276 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
This commit safely allows event names that are named the same as properties that are ordinarily inherited from Object.prototype such as __proto__. Fixes: nodejs#728 PR-URL: nodejs#6092 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
This patch fixes the warning introduced by the changes in e38bade. Ref: nodejs#6092 PR-URL: nodejs#6276 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
This commit safely allows event names that are named the same as properties that are ordinarily inherited from Object.prototype such as __proto__. Fixes: #728 PR-URL: #6092 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
This patch fixes the warning introduced by the changes in e38bade. Ref: #6092 PR-URL: #6276 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
This commit safely allows event names that are named the same as properties that are ordinarily inherited from
Object.prototypesuch as__proto__.Fixes: #728