test: fix flaky test-child-process-fork-net#6138
Closed
+8 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: nodejs#5122
Trott added child_process 
MemberAuthor
Trott commented Apr 10, 2016
Stress test against current master to show failure: https://ci.nodejs.org/job/node-stress-single-test/588/nodes=pi2-raspbian-wheezy/console Stress test with this proposed change to show success: https://ci.nodejs.org/job/node-stress-single-test/590/nodes=pi2-raspbian-wheezy/console |
Member
benjamingr commented Apr 10, 2016
LGTM - why was it 10 to begin with? |
MemberAuthor
Trott commented Apr 10, 2016
Trott added a commit to Trott/io.js that referenced this pull request Apr 12, 2016
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: nodejs#5122 PR-URL: nodejs#6138 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MemberAuthor
Trott commented Apr 12, 2016
Landed in aba035f |
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: #5122 PR-URL: #6138 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: #5122 PR-URL: #6138 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: #5122 PR-URL: #6138 Reviewed-By: Benjamin Gruenbaum <[email protected]>
This was referenced Apr 21, 2016
Closed
Closed
Contributor
MylesBorins commented Apr 21, 2016
@Trott lts? |
MemberAuthor
Trott commented Apr 21, 2016
@thealphanerd Yes, if it lands cleanly. |
jasnell pushed a commit that referenced this pull request Apr 26, 2016
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: #5122 PR-URL: #6138 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: #5122 PR-URL: #6138 Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: #5122 PR-URL: #6138 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test, child_process, arm
Description of change
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.
Fixes: #5122