doc: DCO anchor that doesn't change#6257
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
williamkapke commented Apr 18, 2016
After this is merged, I can fix nodejs/TSC#73 |
Member
addaleax commented Apr 18, 2016
LGTM but I think you want to add a |
Member
lpinca commented Apr 18, 2016
@addaleax correct but I guess it can be added by whoever lands this. |
Member
addaleax commented Apr 18, 2016
@lpinca Yeah, just not sure how urgent this is and @williamkapke can probably fix this. Also, I think there should be a full name in the |
Member
lpinca commented Apr 18, 2016
Totally agree with that :) |
Contributor
cjihrig commented Apr 18, 2016
LGTM |
williamkapke changed the title 
Member
jasnell commented Apr 18, 2016
LGTM |
ContributorAuthor
williamkapke commented Apr 18, 2016
Updated with |
jasnell pushed a commit that referenced this pull request Apr 18, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Apr 18, 2016
Landed in 71801b7 |
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
PR-URL: nodejs#6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
Trott pushed a commit that referenced this pull request Sep 22, 2019
Remove the number '11' as the suffix anchor id for the 'Developer's Certificate of Origin 1.1'. PR-URL: #29468 Refs: #6257 Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 23, 2019
Remove the number '11' as the suffix anchor id for the 'Developer's Certificate of Origin 1.1'. PR-URL: #29468 Refs: #6257 Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
Remove the number '11' as the suffix anchor id for the 'Developer's Certificate of Origin 1.1'. PR-URL: #29468 Refs: #6257 Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
The DCO (Developer's Certificate of Origin) has a version number in it so whenever there is an update to the version, the hash (#) links break. This change just adds an anchor without the version number on it.