doc: add eljefedelrodeodeljefe to collaborators#6389
Uh oh!
There was an error while loading. Please reload this page.
Conversation
ChALkeR commented Apr 26, 2016
LGTM, welcome! |
evanlucas commented Apr 26, 2016
LGTM. Welcome aboard |
santigimeno commented Apr 26, 2016
LGTM and welcome! |
CI: https://ci.nodejs.org/job/node-test-pull-request/2395/ Gonna merge this after CI :) Thanks guys |
PR-URL: #6389 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
eljefedelrodeodeljefe commented Apr 26, 2016
Landed in be5d699 |
eljefedelrodeodeljefe deleted the doc/add-eljefedelrodeodeljefe-to-collaborators branch eljefedelrodeodeljefe commented Apr 26, 2016
With the process in the collaborators guide the PRs won't be marked as merged on GitHub right? Guess it doesn't matter too much. |
Trott commented Apr 26, 2016
@eljefedelrodeodeljefe That's right. @evanlucas told me and others how to make it so that it shows as merged but I don't remember what it was. |
@eljefedelrodeodeljefe@Trott GitHub will label the PR as merged when it sees that all the commits with identical ids are landed on the target branch. |
eljefedelrodeodeljefe commented Apr 26, 2016
Will try that next time then. Thought I did all that. Thanks |
jbergstroem commented Apr 26, 2016
@ChALkeR we should really add that to the collaborators guide -- it makes it easier to make the assumption that the last commit(s) in the PR was also the one's merged. |
jbergstroem commented Apr 26, 2016
@eljefedelrodeodeljefe you have to force push to your branch since you're rewriting history ( |
ChALkeR commented Apr 26, 2016
@eljefedelrodeodeljefe The branch had 3f3f41a, the merged commit was be5d699. Those were not identical =). Update: sorry, copy-pasted wrong commit id. Fixed. |
Yep, after @jbergstroem comments I was realizing that. After adding metadata it needs another force push to the fork. |
PR-URL: #6389 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Git logs print my full name Robert Jefe Lindstaedt. When I did #6389 I forgot simply forgot it. PR-URL: #6880 Reviewed-By: Ben Noordhuis <[email protected]>
Git logs print my full name Robert Jefe Lindstaedt. When I did #6389 I forgot simply forgot it. PR-URL: #6880 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #6389 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Git logs print my full name Robert Jefe Lindstaedt. When I did #6389 I forgot simply forgot it. PR-URL: #6880 Reviewed-By: Ben Noordhuis <[email protected]>
Git logs print my full name Robert Jefe Lindstaedt. When I did #6389 I forgot simply forgot it. PR-URL: #6880 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #6389 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Git logs print my full name Robert Jefe Lindstaedt. When I did #6389 I forgot simply forgot it. PR-URL: #6880 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #6389 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Git logs print my full name Robert Jefe Lindstaedt. When I did #6389 I forgot simply forgot it. PR-URL: #6880 Reviewed-By: Ben Noordhuis <[email protected]>
6 participants
Checklist
Affected core subsystem(s)
docDescription of change
adds me to the readme.md as collaborator