Skip to content

build: don't compile with -B#6393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bnoordhuis merged 1 commit into from
Apr 27, 2016
Merged

build: don't compile with -B #6393

bnoordhuis merged 1 commit into from
Apr 27, 2016

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuisbnoordhuis commented Apr 26, 2016•
edited
Loading

Turn off the custom toolchain, we don't bundle ld.gold. It's not that
useful anyway because it uses a fixed path. For people that do use a
custom toolchain, there is the GCC_EXEC_PREFIX environment variable.

CI: https://ci.nodejs.org/job/node-test-pull-request/2397/

@bnoordhuisbnoordhuis added the build Issues and PRs related to build files or the CI. label Apr 26, 2016
@joaocgreis
Copy link
Member

joaocgreis commented Apr 26, 2016

node-test-commit-arm-fanned job failure was due to work in progress in CI, I will start it again when CI is stable.

@joaocgreis
Copy link
Member

joaocgreis commented Apr 26, 2016

New node-test-commit-arm-fanned: https://ci.nodejs.org/job/node-test-commit-arm-fanned/2395/

@addaleax
Copy link
Member

addaleax commented Apr 27, 2016

LGTM

@bnoordhuis
build: don't compile with -B
3cdb506
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: nodejs#6393 Reviewed-By: Anna Henningsen <[email protected]>
@bnoordhuisbnoordhuisforce-pushed the linux_use_bundled_gold branch from 27ff94c to 3cdb506CompareApril 27, 2016 14:36
@bnoordhuisbnoordhuis deleted the linux_use_bundled_gold branch April 27, 2016 14:36
@bnoordhuisbnoordhuis merged commit 3cdb506 into nodejs:masterApr 27, 2016
@bnoordhuis
Copy link
MemberAuthor

bnoordhuis commented Apr 27, 2016

Thanks, Anna. Release people: this can land in the stable branches but it's a fairly trivial change so feel free to leave it out.

Fishrock123 pushed a commit that referenced this pull request May 4, 2016
@bnoordhuis@Fishrock123
build: don't compile with -B
11e7cc5
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: #6393 Reviewed-By: Anna Henningsen <[email protected]>
This was referenced May 4, 2016
Closed
Merged
@bnoordhuis
Copy link
MemberAuthor

bnoordhuis commented May 6, 2016

Release people: this can land in the stable branches but it's a fairly trivial change so feel free to leave it out.

See #6603, apparently it's needed by at least some people that build from source.

@bnoordhuisbnoordhuis mentioned this pull request May 6, 2016
Closed
@bnoordhuisbnoordhuis mentioned this pull request May 9, 2016
Merged
@bnoordhuis
Copy link
MemberAuthor

bnoordhuis commented May 9, 2016

Release people: #6650 depends on this PR.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request May 10, 2016
@bnoordhuis
build: don't compile with -B, redux
584f93a
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: nodejs#6603 PR-URL: nodejs#6650 Refs: nodejs#6393 Reviewed-By: Anna Henningsen <[email protected]>
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bnoordhuis@evanlucas
build: don't compile with -B, redux
3af9382
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: #6603 PR-URL: #6650 Refs: #6393 Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins
Copy link
Contributor

MylesBorins commented Jun 1, 2016

@bnoordhuis is there value in backporting this or should we just skip it for LTS because of the regression (even though it was patched)

@bnoordhuis
Copy link
MemberAuthor

bnoordhuis commented Jun 2, 2016

This PR together with #6650 fixes #6603 so I think there's some value in back-porting them both.

@MylesBorins
Copy link
Contributor

MylesBorins commented Jun 2, 2016

Thanks @bnoordhuis

MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
@bnoordhuis
build: don't compile with -B
6445b10
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: #6393 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
@bnoordhuis
build: don't compile with -B, redux
7bbf8e0
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: #6603 PR-URL: #6650 Refs: #6393 Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@bnoordhuis
build: don't compile with -B
37606ca
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: #6393 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@bnoordhuis
build: don't compile with -B, redux
a01caa3
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: #6603 PR-URL: #6650 Refs: #6393 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@bnoordhuis
build: don't compile with -B
7c99067
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: #6393 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@bnoordhuis
build: don't compile with -B, redux
e212004
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: #6603 PR-URL: #6650 Refs: #6393 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bnoordhuis@joaocgreis@addaleax@MylesBorins@jasnell