doc: fix EventEmitter#eventNames() example#6417
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
bnoordhuis commented Apr 27, 2016
LGTM but you need to |
ChALkeRforce-pushed the fix-events-doc-mistype branch from 7afa3c0 to 57988daCompare
MemberAuthor
ChALkeR commented Apr 27, 2016
@bnoordhuis Done. |
ChALkeRforce-pushed the fix-events-doc-mistype branch from 57988da to 7bc444dCompare
Contributor
cjihrig commented Apr 27, 2016
LGTM |
Member
jasnell commented Apr 27, 2016
LGTM
|
mscdex added the events mscdex changed the title 
Contributor
mscdex commented Apr 27, 2016
LGTM but commit message still shows 'EventEmmiter' |
MemberAuthor
ChALkeR commented Apr 27, 2016
@mscdex Ah, I didn't notice that, thanks! Will fix that. |
ChALkeRforce-pushed the fix-events-doc-mistype branch from 7bc444d to 5b5105aCompareChALkeR changed the title MemberAuthor
ChALkeR commented Apr 27, 2016
@bnoordhuis, @mscdex Fixed. |
Replace myErr with myEE in one place. Fix the expected output to have the actual formatting. PR-URL: nodejs#6417 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
ChALkeRforce-pushed the fix-events-doc-mistype branch from 5b5105a to 10e3efbCompareMember
bnoordhuis commented Apr 28, 2016
LGTM |
jasnell pushed a commit that referenced this pull request Apr 30, 2016
Replace myErr with myEE in one place. Fix the expected output to have the actual formatting. PR-URL: #6417 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Member
jasnell commented Apr 30, 2016
Landed in c1f2df9 |
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
Replace myErr with myEE in one place. Fix the expected output to have the actual formatting. PR-URL: #6417 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
This was referenced May 4, 2016
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
Replace myErr with myEE in one place. Fix the expected output to have the actual formatting. PR-URL: nodejs#6417 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Contributor
MylesBorins commented Jun 1, 2016
@ChALkeR lts? |
MemberAuthor
ChALkeR commented Jun 2, 2016
@thealphanerd Perhaps. This is mostly just a typo fix in the docs. |
Contributor
moved to don't land @ChALkeR feel free to file a backport PR if you like, it is by no means crucial though |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Replace
myErrwithmyEEin one place (that was obviously a mistype).Fix the expected output to have the actual formatting.
This was overlooked in #5617 (I also didn't notice that).
/cc @jasnell