Skip to content

Conversation

@justshiv
Copy link
Contributor

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Grammar in node.1 file was inconsistent when starting man-page responses (Open vs Opens). I've changed this to ensure these responses are consistent throughout.

@TrottTrott added the doc Issues and PRs related to the documentations. label Apr 27, 2016
@Trott
Copy link
Member

@nodejs/documentation

@Trott
Copy link
Member

LGTM

@Trott
Copy link
Member

CI, just to be thorough: https://ci.nodejs.org/job/node-test-pull-request/2410/

@thefourtheye
Copy link
Contributor

LGTM

@Trott
Copy link
Member

Only CI failure is a currently-problematic test on OS X, so CI is good.

@Trott
Copy link
Member

Should the commit message say ensure instead of ensures? Seems like an unnecessary nit to me, but maybe someone else thinks differently?

@Fishrock123
Copy link
Contributor

LGTM. Commit would be better as ensure, but we can fix that when landing.

@justshiv
Copy link
ContributorAuthor

Ah sorry, the convention in my org is to use third person present verbs 😄

@Fishrock123
Copy link
Contributor

Fishrock123 commented Apr 29, 2016

@justshiv Btw, git thinks your name is justshiv

If you're ok with that, I'll land this as-is.

But if you'd like you can set your name to git by doing:

$ git config --global user.name "whatever you want to be known as" 

and then git commit --amend --reset-author

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 2, 2016
PR-URL: nodejs#6426 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Fishrock123
Copy link
Contributor

Thanks, landed in 8ebec08

We can always .mailmap your name later. :)

Fishrock123 pushed a commit that referenced this pull request May 4, 2016
PR-URL: #6426 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
PR-URL: nodejs#6426 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6426 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
@MylesBorins
Copy link
Contributor

oh hey @justshiv !!! so happy to see you got something into core

@MylesBorinsMylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6426 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6426 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@justshiv@Trott@thefourtheye@Fishrock123@MylesBorins