doc: added note warning about change to console.endTime()#6454
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
doc/api/console.md Outdated
Contributor
There was a problem hiding this comment.
Can you use Node.js v6.0.0 here please?
Maybe also instead of "timeEnd()", do console.timeEnd()
Contributor
evanlucas commented Apr 28, 2016
Thanks for the PR @ben-page! I made a few comments. Let me know if you have any questions. /cc @nodejs/documentation |
Member
jasnell commented Apr 28, 2016
LGTM with nits addressed |
Contributor
eljefedelrodeodeljefe commented Apr 28, 2016
LGTM with @evanlucas nits addressed. Thx. |
Unintended functionality was removed from console.endTime by nodejs#3562. Prior to that, you could call console.endTime multiple times for the same label.
ben-pageforce-pushed the doc-console-endTime branch from b05db6f to dad5c2cCompare
ContributorAuthor
ben-page commented Apr 28, 2016
Thanks for the feedback. I made the changes. |
Contributor
thefourtheye commented Apr 29, 2016
LGTM |
1 similar comment
Contributor
LGTM |
jasnell pushed a commit that referenced this pull request Apr 30, 2016
Unintended functionality was removed from console.endTime by #3562. Prior to that, you could call console.endTime multiple times for the same label. PR-URL: #6454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Lindstaedt <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
Member
jasnell commented Apr 30, 2016
Landed in 541965f |
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
Unintended functionality was removed from console.endTime by #3562. Prior to that, you could call console.endTime multiple times for the same label. PR-URL: #6454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Lindstaedt <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
This was referenced May 4, 2016
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
Unintended functionality was removed from console.endTime by nodejs#3562. Prior to that, you could call console.endTime multiple times for the same label. PR-URL: nodejs#6454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Lindstaedt <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
I added a note warning about a change to console.endTime(). Prior to #3562, you could call console.endTime multiple times for the same label. This was unintended functionality, but the change needed to be documented.
Related Issue: #6452