doc: remove obsolete comment in isError() example#6486
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
One of the util.isError() examples states that a harmony flag is required. As of v6.0.0, this is no longer true. This commit removes the out of date reference. Refs: nodejs#5414
cjihrig added util 
Member
jasnell commented Apr 30, 2016
LGTM |
Member
benjamingr commented Apr 30, 2016
LGTM, not sure why the ping @jasnell this looks like an obvious fix in v6 |
Member
jasnell commented Apr 30, 2016
In general getting in the habit of pinging @nodejs/documentation for anything specifically doc related. |
jasnell pushed a commit that referenced this pull request May 1, 2016
One of the util.isError() examples states that a harmony flag is required. As of v6.0.0, this is no longer true. This commit removes the out of date reference. Refs: #5414 PR-URL: #6486 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Member
jasnell commented May 1, 2016
Landed in d09c972 |
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
One of the util.isError() examples states that a harmony flag is required. As of v6.0.0, this is no longer true. This commit removes the out of date reference. Refs: #5414 PR-URL: #6486 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This was referenced May 4, 2016
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
One of the util.isError() examples states that a harmony flag is required. As of v6.0.0, this is no longer true. This commit removes the out of date reference. Refs: nodejs#5414 PR-URL: nodejs#6486 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
One of the
util.isError()examples states that a harmony flag is required. As of v6.0.0, this is no longer true. This commit removes the out of date reference.Refs: #5414
This should not be backported.