process: add O_NOATIME constant#6492

Trott · 2016-04-30T21:31:44Z

Checklist

tests and code linting passes
a test and/or benchmark is included
the commit message follows commit guidelines

Affected core subsystem(s)

process src test

Description of change

Add O_NOATIME fs flag on Linux.

~~WIP. Do not land (yet). (Running the test first everywhere to make sure results are as expected on all the Linux hosts.)~~

Add O_NOATIME flag on Linux for use with `fs.open()`. PR-URL: nodejs#6492Fixes: nodejs#2182

Trott · 2016-04-30T22:39:29Z

Removed in-progress label. Ready for review.

CI: https://ci.nodejs.org/job/node-test-pull-request/2447/

jasnell · 2016-05-01T02:20:50Z

ha! saw the in progress comment in the PR description, added the label, then scanned lower ;-)

would it be possible to add a test that uses the constant? it's always concerned me that these things aren't documented that well :-(

addaleax · 2016-05-01T02:23:53Z

would it be possible to add a test that uses the constant?

Unfortunately not in a reliable way, the flag is only advisory to the OS/the filesystem.

jasnell · 2016-05-01T02:38:32Z

Didn't think so but didn't hurt to ask ;). Probably the only objection I
can think of on this is that constants is still not documented properly.

It's likely too late to do so now but ideally these kinds of constants
would be exposed via the module in which they are relevant (i.e. fs related
constants on the fs module, crypto related constants on the crypto module).
Add in proper documentation for them, then deprecate require('constants')
entirely (keeping the internal process.binding('constants') tho. Ah well.
On Apr 30, 2016 7:24 PM, "Anna Henningsen" [email protected] wrote:

would it be possible to add a test that uses the constant?
Unfortunately not in a reliable way, the flag is only advisory to the
OS/the filesystem.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#6492 (comment)

bnoordhuis · 2016-05-01T08:23:43Z

LGTM

jbergstroem · 2016-05-01T09:56:31Z

~~O_NOATIME arrived in linux 2.6.8 it seems. Is there a (supported) Linux distribution that we should care about? I couldn't find anything.~~

Edit: Some more pointless googling, treat my comment as noise.

bnoordhuis · 2016-05-01T10:06:05Z

2.6.18 (RHEL 5) is the baseline, it was 2.6.9 (RHEL 4) before that.

Trott · 2016-05-03T00:02:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/2470/

jasnell · 2016-05-03T00:03:16Z

Related: #6534

evanlucas · 2016-05-03T00:03:16Z

should constants be the subsystem?

jasnell · 2016-05-03T16:41:43Z

src: would likely be more appropriate.

jasnell · 2016-05-03T16:42:29Z

LGTM

Add O_NOATIME flag on Linux for use with `fs.open()`. PR-URL: nodejs#6492Fixes: nodejs#2182 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Trott · 2016-05-04T17:19:39Z

Landed in 52f85be

Add O_NOATIME flag on Linux for use with `fs.open()`. PR-URL: #6492Fixes: #2182 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna Henningsen) [#6511](#6511) - **child_process**: use /system/bin/sh on android (Ben Noordhuis) [#6745](#6745) - **deps**: - upgrade npm to 3.8.9 (Rebecca Turner) [#6664](#6664) - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh) [#6572](#6572) - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) [#6796](#6796) - Intl: ICU 57 bump (Steven R. Loomis) [#6088](#6088) - **repl**: - copying tabs shouldn't trigger completion (Eugene Obrezkov) [#5958](#5958) - exports `Recoverable` (Blake Embrey) [#3488](#3488) - **src**: add O_NOATIME constant (Rich Trott) [#6492](#6492) - **src,module**: add --preserve-symlinks command line flag (James M Snell) [#6537](#6537) - **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen) [#6683](#6683)

- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna Henningsen) [#6511](#6511) - **child_process**: use /system/bin/sh on android (Ben Noordhuis) [#6745](#6745) - **deps**: - upgrade npm to 3.8.9 (Rebecca Turner) [#6664](#6664) - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh) [#6572](#6572) - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) [#6796](#6796) - Intl: ICU 57 bump (Steven R. Loomis) [#6088](#6088) - **repl**: - copying tabs shouldn't trigger completion (Eugene Obrezkov) [#5958](#5958) - exports `Recoverable` (Blake Embrey) [#3488](#3488) - **src**: add O_NOATIME constant (Rich Trott) [#6492](#6492) - **src,module**: add --preserve-symlinks command line flag (James M Snell) [#6537](#6537) - **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen) [#6683](#6683) As of this release the 6.X line now includes 64-bit binaries for Linux on Power Systems running in big endian mode in addition to the existing 64-bit binaries for running in little endian mode. PR-URL: #6810

Trott added wip Issues and PRs that are still a work in progress. process Issues and PRs related to the process subsystem. labels Apr 30, 2016

nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 30, 2016

process: add O_NOATIME constant
cf4c83c
Add O_NOATIME flag on Linux for use with `fs.open()`. PR-URL: nodejs#6492Fixes: nodejs#2182

Trott force-pushed the noatime branch from 560db96 to cf4c83cCompare April 30, 2016 22:38

Trott removed the wip Issues and PRs that are still a work in progress. label Apr 30, 2016

Trott mentioned this pull request Apr 30, 2016
Add support for O_NOATIME flag to fs.open #2182
Closed

jasnell added wip Issues and PRs that are still a work in progress. and removed wip Issues and PRs that are still a work in progress. labels May 1, 2016

jasnell mentioned this pull request May 1, 2016
doc: add initial constants module documentation #6505
Closed
1 task

jasnell added c++ Issues and PRs that require attention from people who are familiar with C++. semver-minor PRs that contain new features and should be released in the next minor version. labels May 3, 2016

Trott closed this May 4, 2016

thefourtheye mentioned this pull request May 6, 2016
test: make sure O_NOATIME is present only in Linux #6614
Closed
3 tasks

evanlucas pushed a commit that referenced this pull request May 17, 2016
src: add O_NOATIME constant
37736f4
Add O_NOATIME flag on Linux for use with `fs.open()`. PR-URL: #6492Fixes: #2182 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

evanlucas mentioned this pull request May 17, 2016
2016-05-17, Version 6.2.0 (Stable) #6810
Merged

MylesBorins added the dont-land-on-v4.x label Jun 2, 2016

Trott deleted the noatime branch January 13, 2022 22:43

Uh oh!

process: add O_NOATIME constant#6492

process: add O_NOATIME constant #6492

Uh oh!

Conversation

Trott commented Apr 30, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

Trott commented Apr 30, 2016

Uh oh!

jasnell commented May 1, 2016

Uh oh!

addaleax commented May 1, 2016

Uh oh!

jasnell commented May 1, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bnoordhuis commented May 1, 2016

Uh oh!

jbergstroem commented May 1, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bnoordhuis commented May 1, 2016

Uh oh!

Trott commented May 3, 2016

Uh oh!

jasnell commented May 3, 2016

Uh oh!

evanlucas commented May 3, 2016

Uh oh!

jasnell commented May 3, 2016

Uh oh!

jasnell commented May 3, 2016

Uh oh!

Trott commented May 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Trott commented Apr 30, 2016•
edited
Loading

jasnell commented May 1, 2016•
edited
Loading

jbergstroem commented May 1, 2016•
edited
Loading