doc: revert backported commits#6530
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
MylesBorins commented May 2, 2016
/cc @jasnell |
Member
jasnell commented May 2, 2016
Yep. Looks fine. I'm thinking at this point we should generally slow down on backporting these proactively. As the delta between master and v4 grows, it's going to become more and more important to have the author of the PR to do the porting if it's to be brought back. |
ContributorAuthor
MylesBorins commented May 2, 2016
+1 to that @jasnell |
Member
jasnell commented May 2, 2016
In fact, I would even go so far as to say that unless we get a backport PR, we should hold off cherry-picking the commits from here on out. /cc @nodejs/lts |
ContributorAuthor
MylesBorins commented May 2, 2016
@jasnell I'd like to do one more pass of things that landed in v5... but after that I think that idea is a++ |
Member
jasnell commented May 4, 2016
LGTM |
MylesBorinsforce-pushed the revert-doc-changes branch from 06ea404 to 7f5fdd8CompareThis reverts changes found in daf3ef60943001 that incorrectly updated the docs for `path.format` PR-URL: nodejs#6530 Reviewed-By: James M Snell <[email protected]>
MylesBorinsforce-pushed the revert-doc-changes branch from 7f5fdd8 to b511c5aCompareMylesBorins pushed a commit that referenced this pull request May 6, 2016
This reverts changes found in daf3ef60943001 that incorrectly updated the docs for `path.format` PR-URL: #6530 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
This reverts changes found in daf3ef60943001 that incorrectly updated the docs for `path.format` PR-URL: #6530 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts changes found in daf3ef60943001 that incorrectly
updated the docs for
path.formatcloses#6437