Openssl upgrade v4

[MylesBorins]

Affected core subsystem(s)

tls/crypto

Description of change

openssl sources are upgraded to 1.0.2h and applied floating patches.
One more works was made in this upgrade.

asm regenerated 

asm codes were changed in this upgrade so that asm and asm_obsolete were regenerated. openssl headers were unchanged so that config/ are not regenerated.

Fix: #6458
R: @indutny or @bnoordhuis or @shigeki

[MylesBorins]

/cc @jasnell

[MylesBorins]

ci: https://ci.nodejs.org/job/node-test-pull-request/2485/

[MylesBorins]

Ci is green 🎉🎉🎉

[shigeki]

LGTM. Thanks.

[bnoordhuis]

LGTM although strictly speaking this PR is targeting the wrong branch (v4.x instead of v4.x-staging) and it brings back a couple of files that were removed in 1d0e4a9.

[MylesBorins]

This is targeting 4.x rather than staging as we will be directly cutting off 4.x for the release and not including everything currently on staging

[eyalsach]

for some reason after this fix I can no longer connect to a postgres hosted on aws.
e.g. using code
var pg = require('pg');
pg.connect(connectionString, function(err, client, done){

where connectionString can be something like:
postgres://master:[email protected]:5432/db_demo

I get:{error: password authentication failed for user "master"...

(same issue with ssl=true)

is this a bug or a change that I need to handle differently?

[indutny]

@eyalsach does the same code on a previous node.js version still work?

[bnoordhuis]

See #6782 (comment), this should be reported to node-pg first, unless it's been bisected to exactly this commit (and even then it's still possible node-pg needs to tweak something, so reporting it there is a good first step.)

[eyalsach]

Sure, with v5.10.1 it works fine

On Mon, May 16, 2016 at 8:41 AM, Fedor Indutny [email protected]
wrote:

@eyalsachhttps://github.com/eyalsach does the same code on a previous
node.js version still work?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6551 (comment)

[eyalsach]

Will do, thanks

On Mon, May 16, 2016 at 8:43 AM, Ben Noordhuis [email protected]
wrote:

See #6782 (comment)
#6782 (comment), this
should be reported to node-pg first, unless it's been bisected to exactly
this commit (and even then it's still possible node-pg needs to tweak
something, so reporting it there is a good first step.)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6551 (comment)