test: fix unreliable known_issues test#6555
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
joaocgreis commented May 4, 2016
LGTM |
1 similar comment
Member
jasnell commented May 4, 2016
LGTM |
2 tasks
Member
There was a problem hiding this comment.
Can't you just calculate Math.pow(2, exponent) once in the parent and pass it as argument to the child?
Member
santigimeno commented May 4, 2016
LGTM with a comment |
Contributor
There was a problem hiding this comment.
Is the console.log() needed, or can it be dropped?
Member
There was a problem hiding this comment.
I don’t know if it’s needed, but I’d like to have some way of knowing at what length the test failed after it has run.
MemberAuthor
There was a problem hiding this comment.
I accidentally left it in from debugging. I can add it to the assert message, perhaps.
Contributor
cjihrig commented May 4, 2016
LGTM with nits addressed. |
Member
LGTM, maybe with @santigimeno’s nit addressed if that works too. |
MemberAuthor
Trott commented May 5, 2016
Nits addressed. |
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: nodejs#6527
| [16,18,20].forEach((exponent)=>{ | ||
| constbigNum=Math.pow(2,exponent); | ||
| constlongLine=lineSeed.repeat(bigNum); | ||
| constcmd=`${process.execPath}${__filename} child ${exponent}${bigNum}`; |
Member
There was a problem hiding this comment.
I think the exponent argument is not needed anymore
MemberAuthor
There was a problem hiding this comment.
Strictly speaking, that's true, but I left it in for the assert message.
Member
santigimeno commented May 5, 2016
Still LGTM with one nit |
Trott added a commit to Trott/io.js that referenced this pull request May 6, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: nodejs#6527 PR-URL: nodejs#6555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MemberAuthor
Trott commented May 6, 2016
Landed in c4006dd |
evanlucas pushed a commit that referenced this pull request May 17, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Contributor
MylesBorins commented Jun 2, 2016
@Trott lts? |
MemberAuthor
Trott commented Jun 2, 2016
@thealphanerd Yes |
MylesBorins pushed a commit that referenced this pull request Jun 14, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
test-stdout-buffer-flush-on-exitwas not failing reliably on POSIXmachines and not failing at all on Windows. Revised test fails reliably
on POSIX and is skipped (in CI) on Windows where the issue does not
exist.
Fixes: #6527