Skip to content

Conversation

@bengl
Copy link
Member

@benglbengl commented May 5, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added introduction version metadata in process.md.

Most of the information is gleaned from changelogs. The rest is inferred
from git history.

Omitted cpuUsage() since it's not yet in a release.

Also omitted the streams, events and signals, since I didn't really
think it made sense for those.

Ref: #6578

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 5, 2016
@jasnell
Copy link
Member

Woohoo! Glad to see this moving forward.

@addaleaxaddaleax added the process Issues and PRs related to the process subsystem. label May 5, 2016
@addaleax
Copy link
Member

Yep, great work! You may want to use something like Ref: https://github.com/nodejs/node/issues/6578 in your commit message instead of the last line, because github otherwise thinks this is a full fix for it.

process.send is missing, I looked it up and it seems to have been added in 26c5905 / v0.5.9.

Other than that, LGTM and thank you a lot for the work you put into this!

@bengl
Copy link
MemberAuthor

bengl commented May 5, 2016

@addaleax Fixed commit message and added meta for send.

@jasnell
Copy link
Member

LGTM

1 similar comment
@Qard
Copy link
Member

Qard commented May 6, 2016

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/0.7.2/v0.7.2/ just for consistency?

@estliberitas
Copy link
Contributor

estliberitas commented May 8, 2016

LGTM with nits addressed

Most of the information is gleaned from changelogs. The rest is inferred from git history. Omitted cpuUsage() since it's not yet in a release. Also omitted the streams, events and signals, since I didn't really think it made sense for those. Ref: nodejs#6578
@benglbenglforce-pushed the process_api_intros branch from 3a3be8a to f6950f4CompareMay 8, 2016 20:03
@bengl
Copy link
MemberAuthor

bengl commented May 8, 2016

@estliberitas fixed

addaleax pushed a commit that referenced this pull request May 9, 2016
Most of the information is gleaned from changelogs. The rest is inferred from git history. Omitted cpuUsage() since it's not yet in a release. Also omitted the streams, events and signals, since I didn't really think it made sense for those. Ref: #6578 PR-URL: #6589 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]>
@addaleax
Copy link
Member

Landed in ec67abe.

@addaleaxaddaleax closed this May 9, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
Most of the information is gleaned from changelogs. The rest is inferred from git history. Omitted cpuUsage() since it's not yet in a release. Also omitted the streams, events and signals, since I didn't really think it made sense for those. Ref: #6578 PR-URL: #6589 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]>
@addaleaxaddaleax mentioned this pull request Jul 12, 2016
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
Most of the information is gleaned from changelogs. The rest is inferred from git history. Omitted cpuUsage() since it's not yet in a release. Also omitted the streams, events and signals, since I didn't really think it made sense for those. Ref: nodejs#6578 PR-URL: nodejs#6589 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Most of the information is gleaned from changelogs. The rest is inferred from git history. Omitted cpuUsage() since it's not yet in a release. Also omitted the streams, events and signals, since I didn't really think it made sense for those. Ref: #6578 PR-URL: #6589 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Most of the information is gleaned from changelogs. The rest is inferred from git history. Omitted cpuUsage() since it's not yet in a release. Also omitted the streams, events and signals, since I didn't really think it made sense for those. Ref: #6578 PR-URL: #6589 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Most of the information is gleaned from changelogs. The rest is inferred from git history. Omitted cpuUsage() since it's not yet in a release. Also omitted the streams, events and signals, since I didn't really think it made sense for those. Ref: #6578 PR-URL: #6589 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Most of the information is gleaned from changelogs. The rest is inferred from git history. Omitted cpuUsage() since it's not yet in a release. Also omitted the streams, events and signals, since I didn't really think it made sense for those. Ref: #6578 PR-URL: #6589 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Alexander Makarenko <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@bengl@jasnell@addaleax@Qard@estliberitas@MylesBorins@nodejs-github-bot