tools: lint for use of space in template strings#6591
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There are over 70 files in the project using template strings and all of them have followed the convention of no spaces in curly braces. Good: `${foo}` Not used: `${foo }` Since the project has adopted a convention, and ESLint has a rule to enforce exactly this convention, enable the rule.
Contributor
cjihrig commented May 5, 2016
LGTM |
Contributor
Fishrock123 commented May 5, 2016
lgtm |
Member
JungMinu commented May 5, 2016
LGTM |
1 similar comment
Member
targos commented May 5, 2016
LGTM |
Trott added a commit to Trott/io.js that referenced this pull request May 8, 2016
There are over 70 files in the project using template strings and all of them have followed the convention of no spaces in curly braces. Good: `${foo}` Not used: `${foo }` Since the project has adopted a convention, and ESLint has a rule to enforce exactly this convention, enable the rule. PR-URL: nodejs#6591 Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MemberAuthor
Trott commented May 8, 2016
Landed in 83aa1f7 |
evanlucas pushed a commit that referenced this pull request May 17, 2016
There are over 70 files in the project using template strings and all of them have followed the convention of no spaces in curly braces. Good: `${foo}` Not used: `${foo }` Since the project has adopted a convention, and ESLint has a rule to enforce exactly this convention, enable the rule. PR-URL: #6591 Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
There are over 70 files in the project using template strings and all of
them have followed the convention of no spaces in curly braces.
Good:
${foo}Not used:
${foo }Since the project has adopted a convention, and ESLint has a rule to
enforce exactly this convention, enable the rule.