Skip to content

Conversation

@bengl
Copy link
Member

@benglbengl commented May 5, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added introduction version metadata in url.md and querystring.md.

Ref: #6578

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 5, 2016
@addaleaxaddaleax added querystring Issues and PRs related to the built-in querystring module. url Issues and PRs related to the legacy built-in url module. labels May 5, 2016
@jasnell
Copy link
Member

pinging @nodejs/documentation for review.

@bnoordhuis
Copy link
Member

LGTM

3 similar comments
@jasnell
Copy link
Member

LGTM

@Qard
Copy link
Member

Qard commented May 6, 2016

LGTM

@addaleax
Copy link
Member

LGTM

addaleax pushed a commit that referenced this pull request May 9, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request May 9, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@addaleax
Copy link
Member

Landed in f773073 and 43e4baf.

@addaleaxaddaleax closed this May 9, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
evanlucas pushed a commit that referenced this pull request May 17, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
Module introduced in 7ff04c1. Ref: nodejs#6578 PR-URL: nodejs#6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
Module introduced in 7ff04c1. Ref: nodejs#6578 PR-URL: nodejs#6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Module introduced in 7ff04c1. Ref: #6578 PR-URL: #6593 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.querystringIssues and PRs related to the built-in querystring module.urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@bengl@jasnell@bnoordhuis@Qard@addaleax@MylesBorins@nodejs-github-bot