Skip to content

Conversation

@bengl
Copy link
Member

@benglbengl commented May 6, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add added: information for os.

Via git spelunking, mostly.
Some functions have been renamed. Used the version in which they were
renamed.

Ref: #6578

Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: nodejs#6578
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 6, 2016
@mscdexmscdex added the os Issues and PRs related to the os subsystem. label May 6, 2016
@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

LGTM

@Qard
Copy link
Member

Qard commented May 6, 2016

LGTM too! 👍

@addaleax
Copy link
Member

LGTM, I’m landing these now :)

addaleax pushed a commit that referenced this pull request May 9, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
@addaleax
Copy link
Member

And landed this in 5a8c66a. Thank you!

@addaleaxaddaleax closed this May 9, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: nodejs#6578 PR-URL: nodejs#6609 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.osIssues and PRs related to the os subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@bengl@bnoordhuis@cjihrig@jasnell@Qard@addaleax@mscdex@MylesBorins@nodejs-github-bot