doc: v8 functions as methods on v8#6615
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For consistency with other docs, show v8 functions as being on the v8 object.
Member
bnoordhuis commented May 6, 2016
LGTM |
4 similar comments
Contributor
cjihrig commented May 6, 2016
LGTM |
Member
jasnell commented May 6, 2016
LGTM |
Member
targos commented May 6, 2016
LGTM |
Member
Qard commented May 6, 2016
LGTM |
targos pushed a commit that referenced this pull request May 9, 2016
For consistency with other docs, show v8 functions as being on the v8 object. PR-URL: #6615 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Member
targos commented May 9, 2016
landed in 95d0fee |
evanlucas pushed a commit that referenced this pull request May 17, 2016
For consistency with other docs, show v8 functions as being on the v8 object. PR-URL: #6615 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
For consistency with other docs, show v8 functions as being on the v8
object.